From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#26068: [PATCH] bug in generator function with pcase Date: Sat, 01 Apr 2017 12:12:15 -0400 Message-ID: References: <87efxcp95i.fsf@calancha-pc> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1491063204 22713 195.159.176.226 (1 Apr 2017 16:13:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 1 Apr 2017 16:13:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Mark Oteiza , 26068@debbugs.gnu.org, Tino Calancha To: Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 01 18:13:20 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuLeI-0004Xl-Bk for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Apr 2017 18:13:10 +0200 Original-Received: from localhost ([::1]:52201 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuLeO-0005li-D0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Apr 2017 12:13:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuLeE-0005lV-3i for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 12:13:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuLeA-00028t-Ra for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 12:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cuLeA-00028B-OT for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cuLeA-00032H-D8 for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2017 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2017 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26068-submit@debbugs.gnu.org id=B26068.149106314011611 (code B ref 26068); Sat, 01 Apr 2017 16:13:02 +0000 Original-Received: (at 26068) by debbugs.gnu.org; 1 Apr 2017 16:12:20 +0000 Original-Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuLdU-00031D-4G for submit@debbugs.gnu.org; Sat, 01 Apr 2017 12:12:20 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuLdR-000315-Mz for 26068@debbugs.gnu.org; Sat, 01 Apr 2017 12:12:18 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v31GCFwi021623; Sat, 1 Apr 2017 12:12:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8F558661EE; Sat, 1 Apr 2017 12:12:15 -0400 (EDT) In-Reply-To: (Paul Pogonyshev's message of "Sat, 1 Apr 2017 15:44:16 +0200") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5988=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5988> : inlines <5770> : streams <1739496> : uri <2402034> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131176 Archived-At: > +;; Bug #26068. The problem is that `pcase' uses several `x' symbols, > +;; which are not identical, but have the same name. > +(ert-deftest cps-test-symbols-with-same-name () > + (should (equal (iter-next (funcall (iter-lambda () (pcase (list 1 2) > + (`(,a ,b) (iter-yield (+ a b))))))) > + 3))) Right. I guess the core if the issue would be reproduced with something like (defmacro cl-lib-symbol-macrolet-4+5 () (let* ((sname "x") (s1 (make-symbol sname)) (s2 (make-symbol sname))) `(cl-symbol-macrolet ((,s1 4) (,s2 5)) (+ ,s1 ,s2)))) (ert-deftest cl-lib-symbol-macrolet-2 () (should (equal (cl-lib-symbol-macrolet-4+5) (+ 4 5)))) Before your patch, the macro's code returned 10 rather than 9. I installed this test in cl-lib-tests.el. Stefan