From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Tue, 09 May 2017 20:45:14 -0400 Message-ID: References: <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> <83vapbctij.fsf@gnu.org> <87vapb9dd8.fsf@gnu.org> <877f1qutfq.fsf@drachen> <83wp9qawav.fsf@gnu.org> <0843BD47-5297-4B55-B870-BBE3AEB59D23@gmail.com> <83shkeatlw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494377131 17864 195.159.176.226 (10 May 2017 00:45:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 May 2017 00:45:31 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tino Calancha , Michael Heerdegen , Johan =?windows-1252?Q?Bockg=E5rd?= , emacs-devel , Mark Oteiza , Eli Zaretskii To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 10 02:45:24 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Fkp-0004UI-Kn for ged-emacs-devel@m.gmane.org; Wed, 10 May 2017 02:45:23 +0200 Original-Received: from localhost ([::1]:39931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Fkv-0004sX-0i for ged-emacs-devel@m.gmane.org; Tue, 09 May 2017 20:45:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Fkp-0004sQ-1q for emacs-devel@gnu.org; Tue, 09 May 2017 20:45:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Fko-00065Y-8D for emacs-devel@gnu.org; Tue, 09 May 2017 20:45:23 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:1388) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8Fkj-00063L-An; Tue, 09 May 2017 20:45:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CZAgA9YRJZ/3Z8oWxdGgEBAQECAQEBAQgBAQEBg1WQYpBiKwGXVYYeBAIChG5EFAECAQEBAQEBAWsohRYBBAFWIwULCzQSFBgNJIosCLUDinABAQEHAiaLWIpMAQSeBZUFiQaGeZJ8gUQ2IYEKLyAILodVJIkqAQEB X-IPAS-Result: A0CZAgA9YRJZ/3Z8oWxdGgEBAQECAQEBAQgBAQEBg1WQYpBiKwGXVYYeBAIChG5EFAECAQEBAQEBAWsohRYBBAFWIwULCzQSFBgNJIosCLUDinABAQEHAiaLWIpMAQSeBZUFiQaGeZJ8gUQ2IYEKLyAILodVJIkqAQEB X-IronPort-AV: E=Sophos;i="5.38,316,1491278400"; d="scan'208";a="312441597" Original-Received: from 108-161-124-118.dsl.teksavvy.com (HELO ceviche.home) ([108.161.124.118]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 09 May 2017 20:45:16 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id CCB9E662E0; Tue, 9 May 2017 20:45:14 -0400 (EDT) In-Reply-To: (Jean-Christophe Helary's message of "Wed, 10 May 2017 08:03:55 +0900") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214732 Archived-At: > Since what I propose is consistant with the existing code, not agreeing with > that means *first* finding the bug that Johan mentioned (which is not > directly related to my modification), starting a review process of the whole > code base that uses subr.el/split-string (and maybe other places where that > regexp bug happens), fixing the code to ensure some kind of backward > compatibility, etc. and *then* applying my change to subr-x... I'm pretty sure surrounding the regexp in \(?:..\) will break no code at all. To me it's an absolute no-brainer that doesn't even merit any discussion. Stefan