From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b88e7c8: Make transpose-regions interactive (Bug#30343) Date: Sun, 11 Mar 2018 12:05:11 -0400 Message-ID: References: <20180311105533.30002.78782@vcs0.savannah.gnu.org> <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1520784243 1969 195.159.176.226 (11 Mar 2018 16:04:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2018 16:04:03 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "Charles A. Roelli" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 11 17:03:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ev3S2-0000NP-E1 for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2018 17:03:58 +0100 Original-Received: from localhost ([::1]:54820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev3U5-0002CA-DQ for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2018 12:06:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev3TV-0002C0-5V for emacs-devel@gnu.org; Sun, 11 Mar 2018 12:05:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ev3TS-0008HF-2C for emacs-devel@gnu.org; Sun, 11 Mar 2018 12:05:29 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ev3TR-0008FE-SU for emacs-devel@gnu.org; Sun, 11 Mar 2018 12:05:25 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w2BG5B3Z031892; Sun, 11 Mar 2018 12:05:12 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 5696066666; Sun, 11 Mar 2018 12:05:11 -0400 (EDT) In-Reply-To: <20180311105534.3DAFD23CF3@vcs0.savannah.gnu.org> (Charles A. Roelli's message of "Sun, 11 Mar 2018 06:55:33 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6239=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6239> : inlines <6476> : streams <1781093> : uri <2606348> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223620 Archived-At: > -DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5, 0, > +DEFUN ("transpose-regions", Ftranspose_regions, Stranspose_regions, 4, 5, > + "(if (< (length mark-ring) 2)\ > + (error \"Other region must be marked before transposing two regions\")\ > + (let* ((num (if current-prefix-arg\ > + (prefix-numeric-value current-prefix-arg)\ > + 0))\ > + (ring-length (length mark-ring))\ > + (eltnum (mod num ring-length))\ > + (eltnum2 (mod (1+ num) ring-length)))\ > + (list (point) (mark) (elt mark-ring eltnum) (elt mark-ring eltnum2))))", Am I the only one who dislikes seeing such Elisp code hidden within our C files? Stefan