From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: An idea: combine-change-calls Date: Mon, 26 Mar 2018 17:09:48 -0400 Message-ID: References: <20180324135024.GA6319@ACM> <20180325191424.GE6292@ACM> <20180326201728.GA28620@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522098621 25479 195.159.176.226 (26 Mar 2018 21:10:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Mar 2018 21:10:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 26 23:10:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f0ZNg-0006W0-NL for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2018 23:10:16 +0200 Original-Received: from localhost ([::1]:59134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0ZPk-0006tp-5P for ged-emacs-devel@m.gmane.org; Mon, 26 Mar 2018 17:12:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0ZPc-0006ta-Ja for emacs-devel@gnu.org; Mon, 26 Mar 2018 17:12:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0ZPY-0001o6-KC for emacs-devel@gnu.org; Mon, 26 Mar 2018 17:12:16 -0400 Original-Received: from [195.159.176.226] (port=42579 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0ZPY-0001nv-DF for emacs-devel@gnu.org; Mon, 26 Mar 2018 17:12:12 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1f0ZNT-0006LG-7u for emacs-devel@gnu.org; Mon, 26 Mar 2018 23:10:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 17 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:BSRU4a2bCxxSQBN45nOnukxsG5E= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224076 Archived-At: > This makes undo blindingly fast after a large comment-region operation. > It doesn't always leave point in the right place (I understand why - > it's the C function record_point failing to record point because the top > element of buffer-undo-list is no longer nil; it's a > combine-change-begin list). You can easily fix this by explicitly pushing the position of point onto buffer-undo-list at the beginning. > Basically, the combine-change-calls idea works. Given enough > encouragement, I will get my disorganised changes into a proper patch > with documentation, with a view to pushing it to master. Go, go, go, you can do it! Stefan