From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#31052: 26.0.91; Improve documentation of inline-letevals Date: Wed, 04 Apr 2018 21:12:21 -0400 Message-ID: References: <87a7uj24kk.fsf@runbox.com> <83efjv4ggx.fsf@gnu.org> <83y3i32hhp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1522890671 11458 195.159.176.226 (5 Apr 2018 01:11:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Apr 2018 01:11:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31052@debbugs.gnu.org, Andy Moreton To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 05 03:11:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3tQf-0002pL-74 for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Apr 2018 03:11:05 +0200 Original-Received: from localhost ([::1]:44826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3tSk-0000h8-CW for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Apr 2018 21:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f3tSd-0000g6-0n for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 21:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f3tSY-0008AQ-1k for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 21:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f3tSX-0008AM-U1 for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 21:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f3tSX-0000Ku-N2 for bug-gnu-emacs@gnu.org; Wed, 04 Apr 2018 21:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Apr 2018 01:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31052-submit@debbugs.gnu.org id=B31052.15228907501256 (code B ref 31052); Thu, 05 Apr 2018 01:13:01 +0000 Original-Received: (at 31052) by debbugs.gnu.org; 5 Apr 2018 01:12:30 +0000 Original-Received: from localhost ([127.0.0.1]:38795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3tS2-0000KC-Fh for submit@debbugs.gnu.org; Wed, 04 Apr 2018 21:12:30 -0400 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:64828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f3tRz-0000Jw-NZ for 31052@debbugs.gnu.org; Wed, 04 Apr 2018 21:12:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2E5EQCAd8Va/06mSC1dGwEBAQEDAQEBCQEBAYNCgVCIKZBmgXQTfJRPC4UDAoRBITgUAQIBAQEBAQECAgJoKIUkAQQBeRALDScSFBgxhRgIrmsaAogpgiWHYoITg1w0iiMgAotzi0sIj2ODWYIoIoRnj32BJTMigVIzGggwgn6QaSOOHAEB X-IPAS-Result: A2E5EQCAd8Va/06mSC1dGwEBAQEDAQEBCQEBAYNCgVCIKZBmgXQTfJRPC4UDAoRBITgUAQIBAQEBAQECAgJoKIUkAQQBeRALDScSFBgxhRgIrmsaAogpgiWHYoITg1w0iiMgAotzi0sIj2ODWYIoIoRnj32BJTMigVIzGggwgn6QaSOOHAEB X-IronPort-AV: E=Sophos;i="5.48,409,1517893200"; d="scan'208";a="26760963" Original-Received: from unknown (HELO fmsmemgm.homelinux.net) ([45.72.166.78]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 21:12:21 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id AC011AE1ED; Wed, 4 Apr 2018 21:12:21 -0400 (EDT) In-Reply-To: <83y3i32hhp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Apr 2018 17:06:42 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144910 Archived-At: >> Also, while looking at inline-letevals in inline.el, I noticed that the >> preceeding macros inline--leteval and inline--letlisteval mention the >> wrong symbol name in their error messages: >> >> (defmacro inline--leteval (_var-exp &rest _body) >> (declare (indent 1) (debug (sexp &rest body))) >> (error "inline-letevals can only be used within define-inline")) >> >> (defmacro inline--letlisteval (_list &rest _body) >> (declare (indent 1) (debug (sexp &rest body))) >> (error "inline-letevals can only be used within define-inline")) >> >> Perhaps these typos can be fixed before the release. > > It's not too late for that, but I'm not sure this is a typo. It could > be deliberate. > > Stefan, can you comment on this, please? Good catch: these aren't typos! The inline-letevals macro expands to calls to inline--leteval and inline--letlisteval and it's easier to have those signal the error than to make inline-letevals check whether we're within a define-inline. The user is not supposed to use inline--leteval or inline--letlisteval manually anywhere at all (as indicated by the "--" in their name), so if those occur it's (presumably) because of an incorrect use of inline-letevals. I'll add a comment about it, to stop other people from trying to "fix" it. Stefan