From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master ed29d9f: Add edebug specs for inline.el Date: Sat, 13 Jul 2019 18:30:18 -0400 Message-ID: References: <20190713160723.15224.93024@vcs0.savannah.gnu.org> <20190713160724.DE848207EF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="139230"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 14 00:30:27 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmQXD-000a7Y-Ma for ged-emacs-devel@m.gmane.org; Sun, 14 Jul 2019 00:30:27 +0200 Original-Received: from localhost ([::1]:58240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmQXC-0007eO-2r for ged-emacs-devel@m.gmane.org; Sat, 13 Jul 2019 18:30:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35846) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmQX9-0007bo-5x for emacs-devel@gnu.org; Sat, 13 Jul 2019 18:30:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmQX8-0004WK-5m for emacs-devel@gnu.org; Sat, 13 Jul 2019 18:30:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64437) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmQX8-0004W3-0d for emacs-devel@gnu.org; Sat, 13 Jul 2019 18:30:22 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3733B444BF4; Sat, 13 Jul 2019 18:30:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0A7D9444BE8; Sat, 13 Jul 2019 18:30:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1563057020; bh=/w7YjM+EHR2bMds86T6786T+5E80jeZYGiuiKMuHCOU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=H14wBdn3VtvlkgS1Cq9xbbUQdoawJIux3T1jFKr6B2DMhazMewfY8SdBaXtm9w4FH TesZQwK5IHZxv+MdCj9uBL3xgHwXM0odAq6Wb09p4e2TRUOQh6twnaT6IQqX+svYqx /YmGYhfvMrsFvSTU+q5JESv9StQt0zMrR9CL/iRNWARkAsPh5CS8aBZvgZYrUAbeq8 8jPfGScYGLej0f0XJh9y+oUI1WV2N3fTwljFtNVt59I8/KVz7DOslEP7kNBI2ys1IR qLgJTKyyk8/5NoyRBO4grTpXqXre4IfDOmT5uw3XihOmbOqC6bW99ccgpcVasHX3yK iVhdG4dOlFHVw== Original-Received: from pastel (104-222-123-229.cpe.teksavvy.com [104.222.123.229]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D3244120588; Sat, 13 Jul 2019 18:30:19 -0400 (EDT) In-Reply-To: <20190713160724.DE848207EF@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Sat, 13 Jul 2019 12:07:24 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238573 Archived-At: > Add edebug specs for inline.el > > * lisp/emacs-lisp/inline.el (inline-quote) > (inline-letevals): Add edebug specs (bug#31051). I don't understand. Those macros already have edebug specs (in their `declare` form). (defmacro inline-quote (_exp) "Similar to backquote, but quotes code and only accepts , and not ,@." (declare (debug t)) (error "inline-quote can only be used within define-inline")) (defmacro inline--leteval (_var-exp &rest _body) (declare (indent 1) (debug (sexp &rest body))) ;; BEWARE: if we're here it's presumably via macro-expansion of ;; inline-letevals, so signal the error in terms of the user's code. (error "inline-letevals can only be used within define-inline")) I can't imagine how adding def-edebug-spec before will make any difference. Stefan