From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juanjose.garciaripoll@gmail.com, emacs-devel@gnu.org
Subject: Re: Optional support for GDI+ on Windows (emacs-28)
Date: Wed, 01 Apr 2020 10:58:29 -0400 [thread overview]
Message-ID: <jwvtv23s1g2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83h7y3z61m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Apr 2020 16:31:17 +0300")
>> >> > we should provide variables to control whether GDI+ is used for each
>> >> > supported image format. HAVE_GDIPLUS should guard code which uses
>> >> > GDI+, but it should NOT decide whether that code is actually used.
>> >> Why bother?
>> > Because I requested it.
>>
>> I understand this part, but really there's a good chance this is
>> wasted effort. The NS port didn't have to jump through those hoops to
>> get its code accepted.
>
> I didn't request anything that could be qualified as jumping through
> hoops. This is our standard implementation paradigm for optional
> features on MS-Windows, you can see it all over the place in w32*.c
> files. Convenience macros are available to make coding this
> more-or-less copy-pasting from some other similar feature.
I don't think "variables to control whether <foo> is used for each
supported <bar>" is comparable to what we do for other
"optional" features on MS-Windows.
Also, for "optional features on MS-Windows", the usual behavior if the
lib is not available at run-time is just not to provide the
corresponding functionality, rather than to fallback on some alternative
C implementation.
IOW, I think what would be comparable is: build with support for GDI+
images only (i.e. without support for images via libpng and friends),
and make sure Emacs does run even if GDI+ is not available (simply with
the limitation that it can't display those images, just like what we
have now if libpng is not available at run time).
Stefan
next prev parent reply other threads:[~2020-04-01 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 19:26 Optional support for GDI+ on Windows (emacs-28) Juan José García-Ripoll
2020-03-31 14:12 ` Eli Zaretskii
2020-03-31 15:35 ` Juan José García-Ripoll
2020-03-31 16:47 ` Eli Zaretskii
2020-03-31 16:57 ` Alan Third
2020-03-31 17:41 ` Eli Zaretskii
2020-03-31 19:36 ` Alan Third
2020-03-31 19:43 ` Stefan Monnier
2020-04-01 2:26 ` Eli Zaretskii
2020-04-01 18:33 ` Alan Third
2020-04-01 19:10 ` Eli Zaretskii
2020-03-31 17:27 ` Stefan Monnier
2020-03-31 17:52 ` Eli Zaretskii
2020-03-31 19:37 ` Stefan Monnier
2020-04-01 13:31 ` Eli Zaretskii
2020-04-01 14:58 ` Stefan Monnier [this message]
2020-04-01 15:45 ` Eli Zaretskii
2020-04-01 18:26 ` Stefan Monnier
2020-04-01 18:39 ` Juanma Barranquero
2020-04-01 19:22 ` Stefan Monnier
2020-04-01 19:24 ` Juanma Barranquero
2020-04-01 19:12 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2020-03-30 23:09 Angelo Graziosi
2020-03-31 8:02 ` Juan José García-Ripoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtv23s1g2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juanjose.garciaripoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.