From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 0bd221b: Fix problem of having the wrong window selected after saving foo.gpg Date: Wed, 30 Sep 2020 13:04:17 -0400 Message-ID: References: <20200930153650.16819.40412@vcs0.savannah.gnu.org> <20200930153652.925A9209AC@vcs0.savannah.gnu.org> <87y2kr1a1l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2127"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 30 19:14:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfg3-0000RR-MM for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 19:14:03 +0200 Original-Received: from localhost ([::1]:39176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNfg2-0007aH-Nd for ged-emacs-devel@m.gmane-mx.org; Wed, 30 Sep 2020 13:14:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfWh-0005qQ-6Q for emacs-devel@gnu.org; Wed, 30 Sep 2020 13:04:23 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfWe-000079-Ss for emacs-devel@gnu.org; Wed, 30 Sep 2020 13:04:22 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B2A7B440916; Wed, 30 Sep 2020 13:04:19 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 69A4E4400D8; Wed, 30 Sep 2020 13:04:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1601485458; bh=n7z47skr5MCAPQddil9zz1nSku7dKrlJYRpTIBlXLL8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kNGO3lEyL4yYcObGENKvg9B34QogXgzGFojWDk3Y8a32iHsw0O/9nXcj81MSmrKg2 Q66sb9IdZbgMlEJJewXYzGiCln4BpHVy+jyG+lCk73EN1SC87+unpgGP+XQoO8FD/E bMi2DXl+KQBpqQKsRmXnkfYKlJmBCeiyijPT+jyI1ybmeIhttBIRnTcX1vcLtgfFUT VF0PfioMAAe8jA8Eb5FgUHn889TDHDHfHdfLPx5iXA591dQgYQ68zQFeIzaJ4dTrAv 8kIayXSuP+f9THsJ4JgdNvQMeWeoja82CKkw6/iA0wp+ajf0E1/My7LzLh22wQUvYW qHSjFN3M0H6rQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 44757120682; Wed, 30 Sep 2020 13:04:18 -0400 (EDT) In-Reply-To: <87y2kr1a1l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 30 Sep 2020 18:52:54 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/30 11:51:22 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256778 Archived-At: >>> * lisp/epa.el (epa--select-keys): Restore the window configuration >>> after selecting the key to use (bug#43703). This also ensures >>> that the buffer we were editing ends up as the current buffer >>> after saving it, instead of selecting a different window. >>> + (let ((conf (current-window-configuration))) >> [...] >>> + (set-window-configuration conf))))) >> >> I think this is called `save-window-excursion`. > > I wasn't sure whether that macro would survive the call to > recursive-edit, but I guess it would. It does the same as your code, yes. >> FWIW, I think `save-window-excursion` is never the right solution >> because it doesn't take into account the case where `pop-to-buffer` >> uses another frame. >> >> I can never remember which is the function to "undo" a `display-buffer`, >> but I believe it's something like `quit-window` or `bury-buffer`. >> We should add a reference to these in the docstring of `display-buffer` >> and `pop-to-buffer`. > > So would a quit-buffer before killing the buffer have fixed the problem > here? I'm not sure, to be honest. I'd use a `save-current-buffer` to be on the safe side. Stefan