From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 9f464cc: Stop using calc for ntlm time computation Date: Tue, 27 Oct 2020 09:45:19 -0400 Message-ID: References: <20200816091703.7193.11125@vcs0.savannah.gnu.org> <20200816091705.318C0209AC@vcs0.savannah.gnu.org> <4DC436E0-825F-4785-9F28-41C761186CB4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37973"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Thomas Fitzsimmons , emacs-devel@gnu.org To: Mattias =?windows-1252?Q?Engdeg=E5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 27 14:47:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXPKC-0009jx-PS for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Oct 2020 14:47:44 +0100 Original-Received: from localhost ([::1]:52410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXPKB-00011v-Oq for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Oct 2020 09:47:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXPHz-00084g-D6 for emacs-devel@gnu.org; Tue, 27 Oct 2020 09:45:28 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXPHw-0002fo-4N for emacs-devel@gnu.org; Tue, 27 Oct 2020 09:45:26 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A167244073F; Tue, 27 Oct 2020 09:45:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3416544071A; Tue, 27 Oct 2020 09:45:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1603806321; bh=JbAtdgR/yhupQznbNf8Nq9IrXomcYFeOpZnIsaBtGBo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NQcWw35QPwFXgZUSROTOguRk9JWqRMsA1c/6idr2e7wmk0OgKbOVH7QfWWg4nq967 xzlaOM3CuNrGo2oYjxZNBT7qTOb5pSuNTLAOIgjlfpw55zAoh5C3vXKOxGwVtcyTIs VnOdqP0VVWQTU6sc0ZeLMhj7MmIQs8S30ptqsEkH0tCLs3RkfMuwR4rLLrFthB1csA f7PDXBPWADGEt4FYlHS6A72LseAGn5NDm57EcBL9PgrKZJzf1dEFKUQ0KePybD26o9 mwpk5KyAHCPTxeTngdAn9Uk/4LCu6MtUm/38IOnFNwO+ctoYTrQDJq9PiuTGz+GtjJ IxjABNHPrT6DQ== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1FFC1202E7; Tue, 27 Oct 2020 09:45:20 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Tue, 27 Oct 2020 09:06:43 -0400") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 09:06:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258497 Archived-At: > Didn't get there yet. Here's my latest attempt: OK, I found another problem in the way I was running the tests, so I think I finally did manage to run them correctly, which indeed finds a real problem: % make EMACS=3D"/usr/bin/emacs" EMACS_EXTRAOPT=3D"-l /u/monnier/src/ema= cs/trunk/lisp/net/ntlm.el" MODULES_EMACSOPT=3D"" test/lisp/net/ntlm-tests make -C test lisp/net/ntlm-tests make[1]=A0: on entre dans le r=E9pertoire =AB=A0/home/monnier/src/emacs= /trunk/test=A0=BB make[2]=A0: on entre dans le r=E9pertoire =AB=A0/home/monnier/src/emacs= /trunk/test=A0=BB GEN lisp/net/ntlm-tests.log Running 1 tests (2020-10-27 09:42:55-0400) Test ntlm-time-to-timestamp backtrace: signal(wrong-type-argument (integerp 1.1644473632001902e+17)) apply(signal (wrong-type-argument (integerp 1.1644473632001902e+17)) (setq value-2 (apply fn-0 args-1)) (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri (if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de (let (form-description-4) (if (unwind-protect (setq value-2 (apply f (let ((value-2 (quote ert-form-evaluation-aborted-3))) (let (form-de (let* ((fn-0 (function equal)) (args-1 (condition-case err (let ((si (let ((time (quote (24471 63910 412962 0)))) (let* ((fn-0 (function=20 (closure (t) nil (let ((time (quote (24471 63910 412962 0)))) (let*=20 ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name ntlm-time-to-timestamp :documentation ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable))=20 ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit (quote (not (tag :unstable))))) command-line-1(("-L" ":." "-l" "/u/monnier/src/emacs/trunk/lisp/net/ command-line() normal-top-level() Test ntlm-time-to-timestamp condition: (wrong-type-argument integerp 1.1644473632001902e+17) FAILED 1/1 ntlm-time-to-timestamp =20=20=20=20 Ran 1 tests, 0 results as expected, 1 unexpected (2020-10-27 09:42:55-0= 400) =20=20=20=20 1 unexpected results: FAILED ntlm-time-to-timestamp The problem is that in `ntlm-tests--time-to-timestamp`, the constant 116444736000000000 is too large. Stefan