Re: master a0f6029: Fix misuses of `byte-compile-macro-environment`

[Stefan Monnier <monnier@iro.umontreal.ca>]

>>     Fix misuses of `byte-compile-macro-environment`
>
> This seems to result in the following test failure with 'make check',
> but strangely not with 'make test/pcase-tests':

Hmm... I wonder why the test code worked before that patch.
The problem is that pcase macros defined with `pcase-defmacro` can't be
used in the same file where they're defined (you need to wrap them in
`eval-and-compile`).
Maybe we should fix that, but the problem is not new, so I'm wondering
why the bug didn't trigger earlier.

> BTW, 'make bootstrap' now emits this warning: 
>
>   In cl--sm-macroexpand:
>   emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare'

Yes, that's good: the warning wanrs about an actual problem.

> (The 'sm' is the artist's signature, right? ;)

Nah, the artist found a good excuse: "s(ymbol-)m(acrolet)"

> Is this the right fix?

Yes, but it doesn't just pacify the byte-compiler: it fixes the source
code (in Emacs-27, this worked by accident, really).


        Stefan