all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Po Lu <luangruo@yahoo.com>
Subject: Re: master 99c637499e: Only apply last change to the clipboard
Date: Tue, 01 Feb 2022 00:20:30 -0500	[thread overview]
Message-ID: <jwvtudjjhe5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20220201021359.C439EC40717@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Mon, 31 Jan 2022 21:13:59 -0500 (EST)")

> @@ -173,6 +173,7 @@ decoded.  If `gui-get-selection' signals an error, return nil."
>    (unless (and (memq window-system '(x haiku))
>                 ;; gui-backend-selection-p might be unreliable on other
>                 ;; window systems.
> +               (eq type 'CLIPBOARD)
>                 (gui-backend-selection-owner-p type))
>      (let ((request-type (if (memq window-system '(x pgtk))
>                              (or x-select-request-type

The comment is weird.  Is it meant to apply to the line of code *above* it?
If so, please move it since we follow the convention to put comments
*before* the code to which they apply.  Also I suspect that you meant to
say `gui-backend-selection-owner-p` rather than
`gui-backend-selection-p` in the comment, right?

BTW rather than use such tests we should probably change
`gui-backend-selection-owner-p` so it can return yes/no/dontknow.


        Stefan




       reply	other threads:[~2022-02-01  5:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164368163944.24305.8528536193885928245@vcs2.savannah.gnu.org>
     [not found] ` <20220201021359.C439EC40717@vcs2.savannah.gnu.org>
2022-02-01  5:20   ` Stefan Monnier [this message]
2022-02-01  5:24     ` master 99c637499e: Only apply last change to the clipboard Po Lu
2022-02-01  5:28       ` Po Lu
2022-02-01 14:59         ` Eli Zaretskii
2022-02-02  0:58           ` Po Lu
2022-02-02  3:32             ` Eli Zaretskii
2022-02-02  4:50               ` Po Lu
2022-02-02 12:49                 ` Eli Zaretskii
2022-02-02 13:51                   ` Po Lu
2022-02-02 14:44                     ` Eli Zaretskii
2022-02-03  1:11                       ` Po Lu
2022-02-03  4:01                         ` Stefan Monnier
2022-02-03  7:48                           ` Eli Zaretskii
2022-02-03 13:32                             ` Stefan Monnier
2022-02-01  5:35       ` Stefan Monnier
2022-02-01  7:40         ` Po Lu
2022-02-01 13:41           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtudjjhe5.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.