From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Redisplay hook error backtraces Date: Thu, 14 Jul 2022 12:18:51 -0400 Message-ID: References: <837d4hw5to.fsf@gnu.org> <83ilo0vnwh.fsf@gnu.org> <83fsj4uvjg.fsf@gnu.org> <83mtdct5ze.fsf@gnu.org> <83bktru74y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6607"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , larsi@gnus.org, emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 14 18:24:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oC1dd-0001Xf-0b for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jul 2022 18:24:29 +0200 Original-Received: from localhost ([::1]:49034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oC1db-00082S-Ep for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jul 2022 12:24:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC1YK-0002mD-QE for emacs-devel@gnu.org; Thu, 14 Jul 2022 12:19:00 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oC1YI-0007wg-9d; Thu, 14 Jul 2022 12:18:59 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CEE96805DE; Thu, 14 Jul 2022 12:18:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C220180394; Thu, 14 Jul 2022 12:18:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657815533; bh=27z0BDNXdTwIsKN4fCvkt7BPA2cJAD/Xn7HEWdhEpMY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WkeJ6dkXOOjZRjUvqGaI5GvY9SUfjyGuDwUeKo1VHUh0uikjO75Q2Su2Xva621He8 ZOKVv9aqacRinzk072zgRo5F5vi5rDntOglXsj5l8tmmdad8dDASdxzXBw8bjgJt78 kkQ0FLgz5tVAbLoIrayCU7OhPNTVN5U6MDNBA5HhYtgYLZZo5rg9VT2pxYE1C1naGq slYOvDcxPdofEKuiDHe2F51oNDDmZaJ9MLxqUcFGq3Bp7B7d3M4ZKHzPkZJL7ItKDp FWLl7sONjAwL/51tSzct9R+TNnkaEkbdIXMm7u/W9enKbr6i8fU0UJ817LCGe8tXBc W0TfmGZCxoWig== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8FDA4120807; Thu, 14 Jul 2022 12:18:53 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Thu, 14 Jul 2022 16:07:33 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292156 Archived-At: >> Aren't they all go through safe_call? > > They do, yes, but so do other things that we don't want to engage the > backtrace mechanism for. Actually, I'm not sure that's the case. Basically the question is whether `safe_call` is used because we don't care about any errors that might be thrown (akin to ignore-errors`) or whether we do care but don't want to let them escape and ruin our lunch (akin to `with-demoted-errors`). Being in redisplay is usually a good reason why we don't want to let errors escape, even we do care about those errors (and hence we need to use a mechanism like the one you're implementing in order to debug those problems), but there can be other such cases that also use `safe_call` and where we would also want to use your new code. Stefan