From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57562: [PATCH] * lisp/emacs-lisp/comp.el (comp-run-async-workers): Fail more gracefully Date: Sat, 03 Sep 2022 11:41:14 -0400 Message-ID: References: <83wnakmqw6.fsf@gnu.org> <83v8q4mq8k.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30477"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57562@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 03 17:42:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUVHd-0007iO-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 17:42:09 +0200 Original-Received: from localhost ([::1]:57744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUVHd-0000eV-2I for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Sep 2022 11:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUVHW-0000e7-L5 for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 11:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUVHW-0004VC-9F for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 11:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oUVHW-0000SO-5T for bug-gnu-emacs@gnu.org; Sat, 03 Sep 2022 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Sep 2022 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57562-submit@debbugs.gnu.org id=B57562.16622196891712 (code B ref 57562); Sat, 03 Sep 2022 15:42:02 +0000 Original-Received: (at 57562) by debbugs.gnu.org; 3 Sep 2022 15:41:29 +0000 Original-Received: from localhost ([127.0.0.1]:42667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUVGz-0000RY-4w for submit@debbugs.gnu.org; Sat, 03 Sep 2022 11:41:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUVGx-0000RM-C2 for 57562@debbugs.gnu.org; Sat, 03 Sep 2022 11:41:27 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0437C100C84; Sat, 3 Sep 2022 11:41:22 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 40D851002CB; Sat, 3 Sep 2022 11:41:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662219676; bh=11ynMeF2HmHiGg0jU8f3LEXK+vOg0CYIWi1i/tRHwlA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=V9KsPNDMQqRz1AqB8XHZgL7qMmKRz8EOSCCUjeSEWwDLCZIuT9MHJEcCLeFrcTXt2 0Wga/gquk1XA7/+PNQenLXfHOjHy7JIK6xV3dD7nJOyMr9H2+og1TkCPBsOD39eMzl D2npxn8zOe4gzjUg8ScNSkHALjtVgDuKBWSt8w5KGBvC/dnd0E1OBoYix1V7gEJcRc qC3KLOa4rd9nY1UvXnTpc8RxL+1yKrhWpt5Ay+JA2JgGg1ip80ww5D31y450SelHwW w7ZpkvUWennRjcNofrJ4JzqMdGlZjo+X1rsVv3URyZKATOxJlEsyONkrKInfDnngR0 ungcS2lm3cDOg== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D25BD12091D; Sat, 3 Sep 2022 11:41:15 -0400 (EDT) In-Reply-To: <83v8q4mq8k.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 03 Sep 2022 18:28:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241424 Archived-At: >> > I have trouble seeing the actual change amongst unrelated whitespace >> > changes. Please show a patch with the minimal necessary change, >> > without all the reformatting. Emacs 28.2 is so close to a release >> > that playing whitespace and formatting games is not appropriate there. >> Hmm... looks like I sent the patch I had on `master`, sorry. >> Here is the cleaner `emacs-28` version. > So this means we will silently skip native-compilation, leaving an > obscure message in a buffer, is that right? In *Messages*, I think, yes. I suspect this message will tend to be repeated later on, whenever a new `.elc` file is loaded. In a sense that's good (less chance that the message will be overlooked) but it also risks hiding other messages. > Maybe this is the best we can do for emacs-28 so close to the release, > but for master wouldn't it be better to use delayed-warning instead? Sounds about right, tho I suspect we might need to do even a bit more on `master`, like disabling lazy native compilation when we bump into this problem, to avoid repeating that same error message, or trying harder to find a writable directory. Stefan