From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58446: 28.2; file-attribute-device-number returns a cons cell instead of an integer Date: Fri, 14 Oct 2022 14:34:09 -0400 Message-ID: References: <87lepmusw5.fsf@posteo.net> <87pmexcn1h.fsf@gnus.org> <87edvd5bun.fsf@gmx.de> <87wn92xql1.fsf@gmx.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23909"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Thierry Volpiatto , Lars Ingebrigtsen , 58446@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 14 20:38:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojPZQ-00060K-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 20:38:08 +0200 Original-Received: from localhost ([::1]:43966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojPZP-0002L1-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 14:38:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojPWR-0000lY-CY for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 14:35:13 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojPWR-00084A-3P for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 14:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojPWQ-0003uL-Ig for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 14:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Oct 2022 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58446 X-GNU-PR-Package: emacs Original-Received: via spool by 58446-submit@debbugs.gnu.org id=B58446.166577246514958 (code B ref 58446); Fri, 14 Oct 2022 18:35:02 +0000 Original-Received: (at 58446) by debbugs.gnu.org; 14 Oct 2022 18:34:25 +0000 Original-Received: from localhost ([127.0.0.1]:38617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPVp-0003tC-0K for submit@debbugs.gnu.org; Fri, 14 Oct 2022 14:34:25 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:35019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojPVm-0003sk-5i for 58446@debbugs.gnu.org; Fri, 14 Oct 2022 14:34:23 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 47782441211; Fri, 14 Oct 2022 14:34:16 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9E16C4411A6; Fri, 14 Oct 2022 14:34:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665772450; bh=d7s0RYF2oegQtVEmV5m/MXB5QeD6kpGa1LYs1gZQf8Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G1sVJZDHSP1C8jMn1aOfp+KMctpXTu8dQRjIhJ/ZT4Tu82gZfwRTJu3UdbgvzghKp 9WVKrdOVa6fC8yMf6JwQqAOyCiI/4ORW2MKbBUu8wQa3y4iNBj1U48TIVoYN0SqIJ1 9m5SdtX6H6r+ygLS0bFlxdjXfLtUhWRffS6tfqXa5WKvFXQFgtEtpKdkIM/Q7EC6wd d/rWelrLF/pie+3oKKvk8CSXQZyfqcoSBCi+39ejzdXF9mUPl/vbTX7XGf8fz8l3jl LFZD90qvyk6nes9ezDldmnCERxvGOELsanEKpU/cyZLg2eHNCTPZN5rPzNlaZXhEdX XxHv5w6lZiGhw== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7200D1208E2; Fri, 14 Oct 2022 14:34:10 -0400 (EDT) In-Reply-To: <87wn92xql1.fsf@gmx.de> (Michael Albinus's message of "Fri, 14 Oct 2022 19:28:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245476 Archived-At: >> - The name `file-attribute-file-number` doesn't sound right >> because it doesn't return a number. > The name is a reminiscence of the existing variable buffer-file-number, > which serves exactly the same purpose. One error doesn't justify another. Maybe a better name would be "file identifier"? >> - I wouldn't use `defsubst` (so it can more easily be modified in the >> future, e.g. in case we add more fields to the attributes or use some >> other representation for attributes). > All other accessor functions for file-attributes are defsubsts. Every `defsubst` should be judged on its own individual value. This one doesn't seem to be justified. >> - I would document it more abstractly, mentioning inode and device >> number only as *examples* of things it might contain. > There is no intention to use it for anything else. It shall return > (nthcdr 10 attributes) like all the other file-attributes accessor > functions return for the respective slots. I did not suggest changing its implementation. Only its documentation. The doc should describe the intended semantics of the return value without documenting how it's implemented. Stefan