all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
@ 2023-05-05 15:07 Jimmy Yuen Ho Wong
  2023-05-06  9:36 ` Eli Zaretskii
  0 siblings, 1 reply; 6+ messages in thread
From: Jimmy Yuen Ho Wong @ 2023-05-05 15:07 UTC (permalink / raw)
  To: 63310


Reproduction:

1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
docstrings-non-ascii-quotes)))`
2. M-x package-install RET move-dup
3. M-x package-install RET monky
4. Observe in the *Compile-Log* buffer the `custom-declare-variable
... docstring has wrong usage of unescaped single quotes (use \= or different quoting)` and `docstring wider than ... characters` mesages

Expectation:

Blacklisting docstrings and docstrings-non-ascii-quotes should not result
in any docstring warnings being emitted during byte compilation.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
  2023-05-05 15:07 bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings Jimmy Yuen Ho Wong
@ 2023-05-06  9:36 ` Eli Zaretskii
  2023-05-06 16:39   ` Jimmy Yuen Ho Wong
  0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-05-06  9:36 UTC (permalink / raw)
  To: Jimmy Yuen Ho Wong; +Cc: 63310, Stefan Monnier

> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Fri, 05 May 2023 16:07:20 +0100
> 
> 
> Reproduction:
> 
> 1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
> docstrings-non-ascii-quotes)))`
> 2. M-x package-install RET move-dup
> 3. M-x package-install RET monky
> 4. Observe in the *Compile-Log* buffer the `custom-declare-variable
> ... docstring has wrong usage of unescaped single quotes (use \= or different quoting)` and `docstring wider than ... characters` mesages
> 
> Expectation:
> 
> Blacklisting docstrings and docstrings-non-ascii-quotes should not result
> in any docstring warnings being emitted during byte compilation.

I don't see any warnings when compiling the latest version of
move-dup.

As for monkey: it explicitly sets the value of byte-compile-warnings
in file-local variables:

  ;; Local Variables:
  ;; byte-compile-warnings: (not cl-functions)
  ;; End:

So this overrides your customization when byte-compiling this file.

I see no bug here.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
  2023-05-06  9:36 ` Eli Zaretskii
@ 2023-05-06 16:39   ` Jimmy Yuen Ho Wong
  2023-05-06 16:55     ` Eli Zaretskii
  2023-05-06 18:41     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 6+ messages in thread
From: Jimmy Yuen Ho Wong @ 2023-05-06 16:39 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 63310, Stefan Monnier

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Sorry both message came from monky. I didn't notice the file local
variables set at the bottom. There is indeed no bug here, sorry about this,
you can close this.
Jimmy


On Sat, May 6, 2023 at 10:35 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> > Date: Fri, 05 May 2023 16:07:20 +0100
> >
> >
> > Reproduction:
> >
> > 1. `(custom-set-variables '(byte-compile-warnings '(not docstrings
> > docstrings-non-ascii-quotes)))`
> > 2. M-x package-install RET move-dup
> > 3. M-x package-install RET monky
> > 4. Observe in the *Compile-Log* buffer the `custom-declare-variable
> > ... docstring has wrong usage of unescaped single quotes (use \= or
> different quoting)` and `docstring wider than ... characters` mesages
> >
> > Expectation:
> >
> > Blacklisting docstrings and docstrings-non-ascii-quotes should not result
> > in any docstring warnings being emitted during byte compilation.
>
> I don't see any warnings when compiling the latest version of
> move-dup.
>
> As for monkey: it explicitly sets the value of byte-compile-warnings
> in file-local variables:
>
>   ;; Local Variables:
>   ;; byte-compile-warnings: (not cl-functions)
>   ;; End:
>
> So this overrides your customization when byte-compiling this file.
>
> I see no bug here.
>

[-- Attachment #2: Type: text/html, Size: 1927 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
  2023-05-06 16:39   ` Jimmy Yuen Ho Wong
@ 2023-05-06 16:55     ` Eli Zaretskii
  2023-05-13 14:03       ` Eli Zaretskii
  2023-05-06 18:41     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-05-06 16:55 UTC (permalink / raw)
  To: Jimmy Yuen Ho Wong; +Cc: 63310, monnier

> From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> Date: Sat, 6 May 2023 17:39:56 +0100
> Cc: 63310@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> 
> Sorry both message came from monky. I didn't notice the file local variables set at the bottom. There is
> indeed no bug here, sorry about this, you can close this.

Thanks.

Stefan, any thoughts or comments before I close this?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
  2023-05-06 16:39   ` Jimmy Yuen Ho Wong
  2023-05-06 16:55     ` Eli Zaretskii
@ 2023-05-06 18:41     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 0 replies; 6+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-05-06 18:41 UTC (permalink / raw)
  To: Jimmy Yuen Ho Wong; +Cc: Eli Zaretskii, 63310

> Sorry both message came from monky. I didn't notice the file local
> variables set at the bottom.
[...]
>>   ;; Local Variables:
>>   ;; byte-compile-warnings: (not cl-functions)
>>   ;; End:

BTW, this setting is either obsolete (if the package uses `cl-lib`) or
should be made obsolete (by moving to `cl-lib`).


        Stefan






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings
  2023-05-06 16:55     ` Eli Zaretskii
@ 2023-05-13 14:03       ` Eli Zaretskii
  0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2023-05-13 14:03 UTC (permalink / raw)
  To: 63310-done

> Cc: 63310@debbugs.gnu.org, monnier@iro.umontreal.ca
> Date: Sat, 06 May 2023 19:55:41 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
> > Date: Sat, 6 May 2023 17:39:56 +0100
> > Cc: 63310@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> > 
> > Sorry both message came from monky. I didn't notice the file local variables set at the bottom. There is
> > indeed no bug here, sorry about this, you can close this.
> 
> Thanks.
> 
> Stefan, any thoughts or comments before I close this?

Closing.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-05-13 14:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-05 15:07 bug#63310: 29.0.90; Blacklisting docstrings and docstrings-non-ascii-quotes from byte-compile-warnings do not prevent all docstring warnings Jimmy Yuen Ho Wong
2023-05-06  9:36 ` Eli Zaretskii
2023-05-06 16:39   ` Jimmy Yuen Ho Wong
2023-05-06 16:55     ` Eli Zaretskii
2023-05-13 14:03       ` Eli Zaretskii
2023-05-06 18:41     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.