From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Wilhelm Kirschbaum <wkirschbaum@gmail.com>, 67207@debbugs.gnu.org
Subject: bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode
Date: Wed, 15 Nov 2023 17:53:52 -0500 [thread overview]
Message-ID: <jwvttpm3a7j.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <834jhmrdpw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Nov 2023 21:58:03 +0200")
> Stefan, does this mean define-derived-mode has some deficiency?
> Many/most modes defined using it don't have an explicit hook
> definition, so should we now define a mode hook for all of them?
Usually we don't have good ideas of `:options` to provide for hook
variables, so it's not very useful to expose them to Custom.
Also, it's not rare for hook variables to be modified by other packages,
which again votes in favor of not exposing them to Custom.
But some mode maintainers do like to expose them to Custom for their
users' convenience. Usually I look at it as a hint that there's
something missing elsewhere (for the patch at hand, maybe some kind of
`global-eglot-mode` would be a better answer in the longer term).
We could try and extend `define-derived-mode` to allow it to expose the
hook to Custom, with `:options` and whatnot, but it doesn't seem worth
the trouble since the maintainer can use a separate explicit `defcustom`
instead, as the OP's patch does.
Stefan
next prev parent reply other threads:[~2023-11-15 22:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 18:32 bug#67207: [PATCH] Add elixir-ts-mode-hook to elixir-ts-mode Wilhelm Kirschbaum
2023-11-15 19:38 ` Eli Zaretskii
2023-11-15 19:43 ` Wilhelm Kirschbaum
2023-11-15 19:58 ` Eli Zaretskii
2023-11-15 22:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-18 8:32 ` Wilhelm Kirschbaum
2023-11-19 3:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 10:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvttpm3a7j.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=67207@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.