From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69749: (bindat-type sint 32 t) -> unbound variable bitlen Date: Fri, 15 Mar 2024 12:51:36 -0400 Message-ID: References: <82a56165-7684-4f10-a6c4-60ff27de0417@risk-engineering.org> <86cyrytkk7.fsf@gnu.org> <4a7ccaf7-02dc-4cca-b6e7-520ffb45dcac@risk-engineering.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38293"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 69749@debbugs.gnu.org To: Eric Marsden Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 15 17:52:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlAnN-0009jF-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Mar 2024 17:52:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlAnE-00039o-TX; Fri, 15 Mar 2024 12:52:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlAnC-00039a-0l for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 12:52:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlAnB-0000b1-OJ for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 12:52:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlAnl-0001KB-NX for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 12:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Mar 2024 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69749 X-GNU-PR-Package: emacs Original-Received: via spool by 69749-submit@debbugs.gnu.org id=B69749.17105215465003 (code B ref 69749); Fri, 15 Mar 2024 16:53:01 +0000 Original-Received: (at 69749) by debbugs.gnu.org; 15 Mar 2024 16:52:26 +0000 Original-Received: from localhost ([127.0.0.1]:53647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlAnB-0001Ib-OA for submit@debbugs.gnu.org; Fri, 15 Mar 2024 12:52:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlAn7-0001IL-D0 for 69749@debbugs.gnu.org; Fri, 15 Mar 2024 12:52:23 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C3696100170; Fri, 15 Mar 2024 12:51:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1710521497; bh=VTfjkxl+MKjEkJWhJq2u8POXJqgnQuNjoA68wtkvOr8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bhZ15fEWIthJlp91QeLc5IL6qU1eHxGGRbVku24pzqdT9a2zGdKn3lR4N5nmA5EeB Z/0K5KI8pyZups8c5m2LJ4lIqDlqviQJUe0EIHyruLj0YgVKIDuY3VX8WtueI1g1F9 gw70zxe1LsJz5kseVkh3EgQu4qWIynat0jKYEn1BTXNOHGzNkFWM6y6z0AlmdV9mIG SWHkWCIflehM4jR/ddefsl4NFtBPa46KS2h2y4DAXGLb1roUQLzKrqxdKhIrfMB4zC uEl26h27bYpHcS2gB659kJjebAyc+aHhEWBkEBdBQhTHnfD/MIRjzY3Wxc9Bn02AJw mwy0LhWrjXQeQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CC7F910005D; Fri, 15 Mar 2024 12:51:37 -0400 (EDT) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AD5751207CD; Fri, 15 Mar 2024 12:51:37 -0400 (EDT) In-Reply-To: <4a7ccaf7-02dc-4cca-b6e7-520ffb45dcac@risk-engineering.org> (Eric Marsden's message of "Fri, 15 Mar 2024 08:39:11 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281688 Archived-At: >> Your code ends up (via the `sint` of `bindat-type`) relying on the >> `lexical-binding` dialect of ELisp, which is enabled by default in >> `ielm` but not in your file. > Indeed, thanks for the fix. > Perhaps it would be useful for the bindat-type macro to emit a warning wh= en > it is running in the dynamic-binding dialect (at least for the types that > require lexical binding)? Agreed. I just pushed a corresponding patch to `master`. It impacts only `sint` (among the predefined types). > This would have no runtime cost when byte-compiled or native-compiled, > I assume. The patch I installed indeed doesn't impact the performance of the code. The underlying detail which requires `lexical-binding` to be active does cause the code for `sint` to be significantly less efficient than that for `uint`, tho, so if performance is important, you may prefer to use `uint` and do the conversion to a signed integer manually elsewhere. =F0=9F= =99=81 Stefan