From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andrea Corallo <akrl@sdf.org>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/elisp-benchmarks fccb7bbaad 1/2: * Handle 'compilation-safety'
Date: Wed, 15 May 2024 14:03:01 -0400 [thread overview]
Message-ID: <jwvttizdkgm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20240515174925.A0BEFC2BC82@vcs2.savannah.gnu.org> (Andrea Corallo's message of "Wed, 15 May 2024 13:49:25 -0400 (EDT)")
> +(unless (boundp 'compilation-safety)
> + (defvar compilation-safety))
That makes no sense: (defvar compilation-safety) has no runtime effect,
it does not define the variable, it just tells the compiler that the
variable exists elsewhere and is dynamically scoped. Furthermore, it
normally affects only the "current scope", so the effect of this
`defvar` should arguably end when we exit the `unless` (because of how
it's implemented it currently doesn't end when we exit the `unless`).
Stefan
next parent reply other threads:[~2024-05-15 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171579536498.3206.16174588953622583400@vcs2.savannah.gnu.org>
[not found] ` <20240515174925.A0BEFC2BC82@vcs2.savannah.gnu.org>
2024-05-15 18:03 ` Stefan Monnier [this message]
2024-05-15 18:41 ` [elpa] externals/elisp-benchmarks fccb7bbaad 1/2: * Handle 'compilation-safety' Andrea Corallo
2024-05-15 19:49 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvttizdkgm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=akrl@sdf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.