From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/haskell-ts-mode df8d369037: remove indent function useless replace by M-q Date: Tue, 31 Dec 2024 10:14:24 -0500 Message-ID: References: <173549521472.300001.3703786856066422485@vcs3.savannah.gnu.org> <20241229180015.5FF2FD973AF@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Pranshu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 16:14:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSdxE-0006mh-B2 for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 16:14:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSdx4-0007eH-Pe; Tue, 31 Dec 2024 10:14:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSdwz-0007e0-HN for emacs-devel@gnu.org; Tue, 31 Dec 2024 10:14:30 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSdwx-00032U-Pe for emacs-devel@gnu.org; Tue, 31 Dec 2024 10:14:29 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A2FA6100055; Tue, 31 Dec 2024 10:14:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1735658065; bh=EyumyE/BmgFyUgxwiKaknLXrt8jmqILD/TlzVsLiA9c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CVgS91FBdbfTMVovPJX88BdARcBiUD7u2PNtjwf8Ie/mAmU1rNUZcHJ7sqEBpI1vA CTRRgjMFkF7i4ubiFpfTzxRSqYYEiB0GfLxxTUN4/YL5IrIUYPQNqJbmpH1vgL5Mtx 1XktER1hs4CYQ7Oa4UGK9+2oiy5NdpA9q/gJE81WrCcZypW/TDuEJWK/+1mOB49lTB n0e6Ax9Hu1BfPijl+qbowX1FsoFXQiO6yBqc9bsoKzR+PU/Mn9SHvQ5TfAqJ9gwrrJ /ZXoyMrPuiAEWCeWB+kxy1rAc/64v/ugqgXMVvQuAXOfAzAXBe0JITkz/VUxgRrrUT bS9ttEW8XrugQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02AE0100043; Tue, 31 Dec 2024 10:14:25 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CC3DF1205EF; Tue, 31 Dec 2024 10:14:24 -0500 (EST) In-Reply-To: (Pranshu's message of "Tue, 31 Dec 2024 14:25:56 +0530") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327527 Archived-At: > Yeah,I realised that soon after, it should be fixed now I sa the fix pass by, indeed! Enjoy the last bits of 2024, Stefan > On Mon, 30 Dec 2024, 1:15=E2=80=AFam Stefan Monnier, > wrote: > >> > branch: elpa/haskell-ts-mode >> > commit df8d3690375a14ede7079640bc326111f1fb3ddd >> > Author: Pranshu Sharma >> > Commit: Pranshu Sharma >> > >> > remove indent function useless replace by M-q >> [...] >> > (defvar-keymap haskell-ts-mode-map >> > :doc "Keymap for haskell-ts-mode." >> > "C-c C-c" 'haskell-ts-compile-region-and-go >> > "C-c C-r" 'run-haskell >> > - "C-M-q" 'haskell-ts-indent-defun) >> > + 'haskell-ts-indent-defun) >> >> This last line doesn't look right. >> [ Also, I'd recommend you use #' to quote function names. ] >> >> >> Stefan >> >>