From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: autorevert.el
Date: 04 Mar 2004 15:43:40 -0500 [thread overview]
Message-ID: <jwvsmgoic0l.fsf-monnier+emacs/devel@asado.iro.umontreal.ca> (raw)
In-Reply-To: <200403040508.i2458W811551@raven.dms.auburn.edu>
> Not all parts of the function check the modtime and the two parts
> where the modtime gets checked do it in different ways (dired can not
> use `verify-visited-file-modtime', because it is not visiting a file).
> It seems that the only thing that is done unconditionally in all cases
> is check (buffer-modified-p), so I changed the function to first check
> this before splitting into cases.
Too bad we can't do better, but thanks for double checking for me.
> Also, I'd use file-remote-p rather than (string-match "@"),
> especially since remote files might not include any @.
> You are right. I kept this from the original code. I did not check
> this carefully enough. Note that I neither checked the code
> of the vc-part of the original patch, not tested it.
Well, you've already done more than most of us.
> As for the auto-revert-flag thingy, I find it truly ugly because
> I don't like dired knowing about auto-revert just for the sake of
> verbosity control. There's got to be a better way.
> Like what?
Dunno!
> I need some way to tell not only dired, but other non-file
> buffers as well, not to display the revert messages they usually do.
Like which others? And why does dired display a message anyway?
It seems just wrong to me, since the user knows he reverted the buffer if
he did M-x revert-buffer (and indeed M-x revert-buffer in a file buffer
does not output any message). It seems these messages should be output
(when needed) by the code that calls revert-buffer-function.
As does auto-revert, for example.
I.e. I suggest to just throw out the dired messages.
> I do not know whether you question the usefulness of the verbosity
> control itself.
No, your example of `make recompile' was pretty compelling already ;-)
Stefan
next prev parent reply other threads:[~2004-03-04 20:43 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 23:19 autorevert.el Luc Teirlinck
2004-03-03 13:24 ` autorevert.el Stefan Monnier
2004-03-04 5:08 ` autorevert.el Luc Teirlinck
2004-03-04 20:43 ` Stefan Monnier [this message]
2004-03-05 4:00 ` autorevert.el Luc Teirlinck
2004-03-13 3:10 ` autorevert.el Luc Teirlinck
2004-03-13 11:29 ` autorevert.el Kai Grossjohann
2004-03-14 23:15 ` autorevert.el Stefan Monnier
2004-03-15 0:08 ` autorevert.el Luc Teirlinck
2004-03-15 2:58 ` autorevert.el Stefan Monnier
2004-03-15 7:04 ` autorevert.el Eli Zaretskii
2004-03-16 4:56 ` autorevert.el Luc Teirlinck
2004-03-16 19:40 ` autorevert.el Eli Zaretskii
2004-03-19 4:48 ` autorevert.el Luc Teirlinck
2004-03-19 6:06 ` autorevert.el Stefan Monnier
2004-03-21 2:42 ` autorevert.el Luc Teirlinck
2004-03-23 15:26 ` autorevert.el Stefan Monnier
2004-03-24 4:20 ` autorevert.el Luc Teirlinck
2004-03-24 4:25 ` autorevert.el Luc Teirlinck
2004-03-21 4:19 ` autorevert.el Luc Teirlinck
2004-03-19 10:19 ` autorevert.el Kim F. Storm
2004-03-19 14:46 ` autorevert.el Eli Zaretskii
2004-03-21 3:26 ` autorevert.el Luc Teirlinck
2004-03-21 6:46 ` autorevert.el Eli Zaretskii
2004-03-22 2:44 ` autorevert.el Luc Teirlinck
2004-03-22 6:51 ` autorevert.el Eli Zaretskii
2004-03-22 19:39 ` autorevert.el Luc Teirlinck
2004-03-23 19:40 ` autorevert.el Eli Zaretskii
2004-03-23 20:09 ` autorevert.el Stefan Monnier
2004-03-24 4:10 ` autorevert.el Luc Teirlinck
2004-03-24 6:58 ` autorevert.el Eli Zaretskii
2004-03-24 18:03 ` autorevert.el Stefan Monnier
2004-03-25 6:56 ` autorevert.el Eli Zaretskii
2004-03-25 17:01 ` autorevert.el Stefan Monnier
2004-03-24 18:56 ` autorevert.el Luc Teirlinck
2004-03-25 6:20 ` autorevert.el Luc Teirlinck
2004-03-25 6:49 ` autorevert.el Luc Teirlinck
2004-03-25 7:21 ` autorevert.el Eli Zaretskii
2004-03-22 19:47 ` autorevert.el Luc Teirlinck
2004-03-22 16:23 ` autorevert.el Stefan Monnier
2004-03-23 4:24 ` autorevert.el Eli Zaretskii
2004-03-21 19:22 ` autorevert.el Richard Stallman
2004-03-16 5:06 ` autorevert.el Luc Teirlinck
2004-03-05 4:25 ` autorevert.el Luc Teirlinck
2004-03-05 5:55 ` autorevert.el Luc Teirlinck
2004-03-04 5:34 ` autorevert.el Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsmgoic0l.fsf-monnier+emacs/devel@asado.iro.umontreal.ca \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.