From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: find-file-noselect needs save-match-data Date: Tue, 05 Jun 2007 21:13:14 -0400 Message-ID: References: <46643852.6070709@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181092429 29061 80.91.229.12 (6 Jun 2007 01:13:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 6 Jun 2007 01:13:49 +0000 (UTC) Cc: Herbert Euler , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 06 03:13:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hvk5r-0002zG-RL for ged-emacs-devel@m.gmane.org; Wed, 06 Jun 2007 03:13:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hvk5r-0003zr-AD for ged-emacs-devel@m.gmane.org; Tue, 05 Jun 2007 21:13:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hvk5n-0003zm-Fp for emacs-devel@gnu.org; Tue, 05 Jun 2007 21:13:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hvk5l-0003zI-P6 for emacs-devel@gnu.org; Tue, 05 Jun 2007 21:13:43 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hvk5l-0003zC-L7 for emacs-devel@gnu.org; Tue, 05 Jun 2007 21:13:41 -0400 Original-Received: from toq9.bellnexxia.net ([209.226.175.116] helo=toq9-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hvk5l-0008Pn-97 for emacs-devel@gnu.org; Tue, 05 Jun 2007 21:13:41 -0400 Original-Received: from ceviche.home ([70.55.144.218]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070606011314.LWNO9197.tomts10-srv.bellnexxia.net@ceviche.home> for ; Tue, 5 Jun 2007 21:13:14 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8C2E5B4C29; Tue, 5 Jun 2007 21:13:14 -0400 (EDT) In-Reply-To: <46643852.6070709@gmx.at> (martin rudalics's message of "Mon\, 04 Jun 2007 18\:05\:38 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72308 Archived-At: > While you're there, could you look at some other functions in > files.el as well? At least `convert-standard-filename', > `file-truename', `file-name-sans-versions', `insert-directory', > could benefit from `save-match-data' too. No. Most functions should not need to save-match-data (which is an expensive operation very rarely needed). The place to save-match-data is typically on functions that use regexps and are placed on some sensitive hooks (or at the pbvious place when a function needs to call regexp-manipulating code between a regexp-match and its use of the match-data). Stefan