From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: propose adding Icicles to Emacs Date: Mon, 11 Jun 2007 17:46:26 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181598405 5266 80.91.229.12 (11 Jun 2007 21:46:45 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2007 21:46:45 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 11 23:46:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hxrig-0008Sd-Ct for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 23:46:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hxrif-0007Nd-Q5 for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 17:46:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hxrib-0007LQ-SF for emacs-devel@gnu.org; Mon, 11 Jun 2007 17:46:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hxrib-0007L9-F4 for emacs-devel@gnu.org; Mon, 11 Jun 2007 17:46:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hxrib-0007L6-A8 for emacs-devel@gnu.org; Mon, 11 Jun 2007 17:46:33 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hxria-0005cv-3K; Mon, 11 Jun 2007 17:46:32 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A742E2CEB87; Mon, 11 Jun 2007 17:46:31 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 765A33FE0; Mon, 11 Jun 2007 17:46:26 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 5D7524C6D25; Mon, 11 Jun 2007 17:46:26 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Mon\, 11 Jun 2007 13\:53\:18 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72653 Archived-At: >> Redefining completing-read is a no-no in my book. Please try to rewrite >> your code so as not to do that (e.g. using minibuffer-setup-hook). > I don't see how to do that. Concrete suggestions welcome. Please have > a look at the existing code. Likewise for the other, related functions > (`read-file-name', etc.). I'd rather it be the other way around: tell us what you're trying to do (and finding you cannot do). > I'm not sure why the redefinition within Icicle mode is a no-no. I'm not > arguing, but I don't see the reason for the prohibition. It's OK for an external package (tho I prefer defadvice), but for reasons of maintainability and general principle it's not good inside Emacs. We probably do have such things already inside Emacs, but we want to reduce such occurrences rather than increase them. > Perhaps if you explain what you mean about using minibuffer-setup-hook, > there will be no need. E.g. Why not do the fiddling of initial-input with icicle-initial-value in a minibuffer-setup-hook? Stefan