From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: mark_object crash in 22.1 and latest CVS (as of tonight) Date: Fri, 16 Nov 2007 14:04:18 -0500 Message-ID: References: <16af2f430711081955j3d5e6745gc0f7a50e02d9a892@mail.gmail.com> <16af2f430711120340q27926877tf976ef397d12df16@mail.gmail.com> <16af2f430711140939x45663644je0dce25c8796b18@mail.gmail.com> <16af2f430711141700g74175advd8f234478293faa5@mail.gmail.com> <16af2f430711160405p6a734839lb24610ee65257498@mail.gmail.com> <16af2f430711160607m158b9c98xa401166709f628ff@mail.gmail.com> <473DD32F.5070501@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195239886 13029 80.91.229.12 (16 Nov 2007 19:04:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2007 19:04:46 +0000 (UTC) Cc: Kalman Reti , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 16 20:04:51 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1It6Uc-00035r-5a for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2007 20:04:42 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It6UO-0004Hx-SJ for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2007 14:04:28 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1It6UL-0004FV-Ec for emacs-devel@gnu.org; Fri, 16 Nov 2007 14:04:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1It6UJ-0004Av-Jg for emacs-devel@gnu.org; Fri, 16 Nov 2007 14:04:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1It6UJ-0004Ag-Fx for emacs-devel@gnu.org; Fri, 16 Nov 2007 14:04:23 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1It6UJ-0004Ij-7C for emacs-devel@gnu.org; Fri, 16 Nov 2007 14:04:23 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id AA5E62CF2EF; Fri, 16 Nov 2007 14:04:22 -0500 (EST) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id A0C2F3FE0; Fri, 16 Nov 2007 14:04:18 -0500 (EST) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 8CFEF6CA9C; Fri, 16 Nov 2007 14:04:18 -0500 (EST) In-Reply-To: <473DD32F.5070501@gmx.at> (martin rudalics's message of "Fri, 16 Nov 2007 18:28:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83368 Archived-At: > If I understand correctly, this means that either markers used for > saving match-data should not go to `buffer-undo-list' or the "evaporate" > option set by `save-match-data' is inherently broken. The `evaporate' option is inherently dangerous since it reclaims the marker object forcefully without checking that nobody else is holding on to it, even tho it comes from a plain normal argument and the caller may very well have kept another ref to it somewhere. I suggest we kill it, Stefan --- orig/src/search.c +++ mod/src/search.c @@ -3023,10 +3023,7 @@ if (!NILP (reseat) && MARKERP (m)) { - if (EQ (reseat, Qevaporate)) - free_marker (m); - else - unchain_marker (XMARKER (m)); + unchain_marker (XMARKER (m)); XSETCAR (list, Qnil); } @@ -3044,10 +3041,7 @@ if (!NILP (reseat) && MARKERP (m)) { - if (EQ (reseat, Qevaporate)) - free_marker (m); - else - unchain_marker (XMARKER (m)); + unchain_marker (XMARKER (m)); XSETCAR (list, Qnil); } } @@ -3111,8 +3105,7 @@ unwind_set_match_data (list) Lisp_Object list; { - /* It is safe to free (evaporate) the markers immediately. */ - return Fset_match_data (list, Qevaporate); + return Fset_match_data (list, Qt); } /* Called to unwind protect the match data. */