From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: nxml-mode uses wrong method to run 'nxml-mode-hook Date: Mon, 16 Jun 2008 12:34:11 -0400 Message-ID: References: <18516.44650.776858.871951@priss.frightenedpiglet.com> <4856331F.6040500@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213634091 28962 80.91.229.12 (16 Jun 2008 16:34:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2008 16:34:51 +0000 (UTC) Cc: sand@blarg.net, emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 16 18:35:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K8Hg6-0008BB-Tq for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 18:35:35 +0200 Original-Received: from localhost ([127.0.0.1]:48563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8HfI-0007jD-L3 for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 12:34:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8HfE-0007j7-Uz for emacs-devel@gnu.org; Mon, 16 Jun 2008 12:34:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8HfD-0007is-GD for emacs-devel@gnu.org; Mon, 16 Jun 2008 12:34:39 -0400 Original-Received: from [199.232.76.173] (port=58344 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8HfD-0007ip-Av for emacs-devel@gnu.org; Mon, 16 Jun 2008 12:34:39 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:38310) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K8Hf8-0005VM-MF; Mon, 16 Jun 2008 12:34:34 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 458802CFD34; Mon, 16 Jun 2008 12:34:34 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id D7AFE3FE0; Mon, 16 Jun 2008 12:34:11 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id CBA4E41BEC; Mon, 16 Jun 2008 12:34:11 -0400 (EDT) In-Reply-To: <4856331F.6040500@gnu.org> (Jason Rumney's message of "Mon, 16 Jun 2008 10:32:15 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99307 Archived-At: >> The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554; >> your mileage may vary) has >> >> (run-hooks 'nxml-mode-hook) >> >> It should use 'run-mode-hooks', because this is a major mode >> definition. Can someone fix that? >> >> It looks like there are some other major modes with the same problem. >> For example: terminal-mode, view-mode, remember-mode, erc, rmail, >> rcirc. Most of the matches below are minor modes, though. > The other major modes don't seem to be editing modes, and most of them have > been in Emacs for a long time, so I am not sure if they should be changed, > or if they have been left deliberately. They should all use run-mode-hooks, AFAIK. So unless there's a comment justifying the use of `run-hooks', it should be changed. > But I have changed nxml-mode. Thank you, Stefan