From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs client/server mode hardcodes /tmp path Date: Wed, 29 Oct 2008 11:03:49 -0400 Message-ID: References: <18695.5574.107271.711561@a1i15.kph.uni-mainz.de> <18696.5661.523071.167994@a1ihome1.kph.uni-mainz.de> <18696.11434.978893.578213@a1i15.kph.uni-mainz.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225292731 7862 80.91.229.12 (29 Oct 2008 15:05:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Oct 2008 15:05:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 29 16:06:33 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KvCbz-0003mo-1G for ged-emacs-devel@m.gmane.org; Wed, 29 Oct 2008 16:05:51 +0100 Original-Received: from localhost ([127.0.0.1]:41875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvCas-0005Te-Eg for ged-emacs-devel@m.gmane.org; Wed, 29 Oct 2008 11:04:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KvCaR-0005Gk-4T for emacs-devel@gnu.org; Wed, 29 Oct 2008 11:03:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KvCaP-0005F7-E5 for emacs-devel@gnu.org; Wed, 29 Oct 2008 11:03:54 -0400 Original-Received: from [199.232.76.173] (port=35545 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KvCaP-0005F1-5p for emacs-devel@gnu.org; Wed, 29 Oct 2008 11:03:53 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20726) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KvCaO-00069f-Ih for emacs-devel@gnu.org; Wed, 29 Oct 2008 11:03:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUEAAQYCElMCqyo/2dsb2JhbACBdst/g1GBDg X-IronPort-AV: E=Sophos;i="4.33,506,1220241600"; d="scan'208";a="29013478" Original-Received: from 76-10-172-168.dsl.teksavvy.com (HELO pastel.home) ([76.10.172.168]) by ironport2-out.teksavvy.com with ESMTP; 29 Oct 2008 11:03:51 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 892AA8E6F; Wed, 29 Oct 2008 11:03:49 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Wed, 29 Oct 2008 15:55:55 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105146 Archived-At: >> Please just leave it as 100. The rest of the code uses 100 everywhere. > Not in emacsclient.c. In src/, I see 100 mostly used as > char tmp_buf[100]; > and similar; but as a size for alloca (), xmalloc () etc. it appears > only a few times, alone or as part of an expression. Whether it's for a static or dynamic allocation doesn't matter: the places where some arbitrary number is used, it's usually 100. >> Otherwise, define a macro (which you can set to 42 if you really insist) >> and use it everywhere. > I've already checked the patch with 32, which seems a fine default: a > power of two and small (and it is used a few times already on > emacsclient.c). 42 was obviously only a joke. Actually 32 is no better than 42 or 100. The important part is that people shouldn't feel compelled to change 100 to 96 (or 32 to 28) when they reduce a size by 4. > But if you insist I can change all these 32 to 100. Or use a macro for > all these EXTRA_SPACE, if you suggest a good name for it. EXTRA_SPACE sounds fine, Stefan