From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs client/server mode hardcodes /tmp path
Date: Wed, 29 Oct 2008 11:03:49 -0400 [thread overview]
Message-ID: <jwvskqfxx5g.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <f7ccd24b0810290755v2351371u9a797bd833f5d045@mail.gmail.com> (Juanma Barranquero's message of "Wed, 29 Oct 2008 15:55:55 +0100")
>> Please just leave it as 100. The rest of the code uses 100 everywhere.
> Not in emacsclient.c. In src/, I see 100 mostly used as
> char tmp_buf[100];
> and similar; but as a size for alloca (), xmalloc () etc. it appears
> only a few times, alone or as part of an expression.
Whether it's for a static or dynamic allocation doesn't matter: the
places where some arbitrary number is used, it's usually 100.
>> Otherwise, define a macro (which you can set to 42 if you really insist)
>> and use it everywhere.
> I've already checked the patch with 32, which seems a fine default: a
> power of two and small (and it is used a few times already on
> emacsclient.c). 42 was obviously only a joke.
Actually 32 is no better than 42 or 100. The important part is that
people shouldn't feel compelled to change 100 to 96 (or 32 to 28) when
they reduce a size by 4.
> But if you insist I can change all these 32 to 100. Or use a macro for
> all these EXTRA_SPACE, if you suggest a good name for it.
EXTRA_SPACE sounds fine,
Stefan
next prev parent reply other threads:[~2008-10-29 15:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 15:43 emacs client/server mode hardcodes /tmp path Diego 'Flameeyes' Pettenò
2008-03-06 17:48 ` Stefan Monnier
2008-03-06 17:58 ` Diego 'Flameeyes' Pettenò
2008-10-28 13:38 ` Ulrich Mueller
2008-10-28 14:29 ` Stefan Monnier
2008-10-29 7:51 ` Ulrich Mueller
2008-10-29 9:15 ` Juanma Barranquero
2008-10-29 9:28 ` Ulrich Mueller
2008-10-29 9:37 ` Juanma Barranquero
2008-10-29 14:41 ` Stefan Monnier
2008-10-29 14:55 ` Juanma Barranquero
2008-10-29 15:03 ` Stefan Monnier [this message]
2008-10-29 15:12 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvskqfxx5g.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.