From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: dropped 4th arg from all-completions Date: Tue, 27 Apr 2010 14:12:02 -0400 Message-ID: References: <226EA936D1DE4CDE9B80702AA1B3F1DD@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1272391944 619 80.91.229.12 (27 Apr 2010 18:12:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 27 Apr 2010 18:12:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 27 20:12:20 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O6pGd-0003aL-VO for ged-emacs-devel@m.gmane.org; Tue, 27 Apr 2010 20:12:20 +0200 Original-Received: from localhost ([127.0.0.1]:41888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6pGd-0006h3-8v for ged-emacs-devel@m.gmane.org; Tue, 27 Apr 2010 14:12:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O6pGW-0006eM-SY for emacs-devel@gnu.org; Tue, 27 Apr 2010 14:12:12 -0400 Original-Received: from [140.186.70.92] (port=42006 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O6pGQ-0006Zg-QX for emacs-devel@gnu.org; Tue, 27 Apr 2010 14:12:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O6pGN-0002a6-Vn for emacs-devel@gnu.org; Tue, 27 Apr 2010 14:12:06 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:19456 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O6pGN-0002Zn-Qw for emacs-devel@gnu.org; Tue, 27 Apr 2010 14:12:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAEfG1kvO+KoL/2dsb2JhbACcTXLBeYUOBIwP X-IronPort-AV: E=Sophos;i="4.52,282,1270440000"; d="scan'208";a="62701954" Original-Received: from 206-248-170-11.dsl.teksavvy.com (HELO pastel.home) ([206.248.170.11]) by ironport2-out.pppoe.ca with ESMTP; 27 Apr 2010 14:12:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id B499E7F22; Tue, 27 Apr 2010 14:12:02 -0400 (EDT) In-Reply-To: <226EA936D1DE4CDE9B80702AA1B3F1DD@us.oracle.com> (Drew Adams's message of "Tue, 27 Apr 2010 09:01:51 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124252 Archived-At: > I object to Emacs 23.2 dropping the 4th arg from `all-completions'. My 23.2 code shows all-completions accepts 4 args. Heck, even the 24 branch still accepts 4 args. > I do not understand why the feature of ignoring candidates that start > with a space was removed. It doesn't have its place in `all-completions' (which is an internal function, and hence not directly related to any UI feature). > FWIW, I use this 4th arg. I even have a user option and a minibuffer > toggle key that lets users control the removal of such candidates. > If you don't want to use the feature, that's one thing, but why remove > it from Emacs? You can get the same result by changing the completion table instead, or by changing the `predicate'. These approaches also have the advantage of being a lot more flexible. Stefan