From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 8463@debbugs.gnu.org, Daniel Colascione <dan.colascione@gmail.com>
Subject: bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer
Date: Thu, 14 Apr 2011 22:11:06 -0300 [thread overview]
Message-ID: <jwvsjtkuxqo.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1lizi5xqa.fsf@th041153.ip.tsinghua.edu.cn> (Leo's message of "Sun, 10 Apr 2011 16:14:53 +0800")
> @@ -761,7 +761,8 @@
> (let ((map (make-sparse-keymap)))
> ;; We use this alternative name, so we can use \\[occur-mode-mouse-goto].
> (define-key map [mouse-2] 'occur-mode-mouse-goto)
> - (define-key map "\C-c\C-c" 'occur-mode-goto-occurrence)
> + (define-key map "\C-c\C-c" 'occur-edit-mode)
> + (define-key map "\C-x\C-q" 'occur-edit-mode)
> (define-key map "\C-m" 'occur-mode-goto-occurrence)
> (define-key map "o" 'occur-mode-goto-occurrence-other-window)
> (define-key map "\C-o" 'occur-mode-display-occurrence)
I haven't had a chance to look much at the code, but while the
functionality generally sounds good, the C-c C-c binding above doesn't
look right to me. I think C-x C-q is sufficient and there's no need to
introduce such an incompatibility (not with code but with users).
Stefan
next prev parent reply other threads:[~2011-04-15 1:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 8:14 bug#8463: 24.0.50; [PATCH] Direct Edit in *Occur* Buffer Leo
2011-04-15 1:11 ` Stefan Monnier [this message]
2011-05-28 23:05 ` Chong Yidong
2011-05-29 4:04 ` Leo
2011-05-30 14:04 ` Andrew W. Nosenko
2011-05-30 23:10 ` Richard Stallman
2011-06-01 23:03 ` Glenn Morris
2011-06-03 2:36 ` Leo
2011-06-03 15:38 ` Stefan Monnier
2011-06-04 21:34 ` Chong Yidong
2011-06-05 9:30 ` Štěpán Němec
2011-06-06 15:34 ` Stefan Monnier
2011-06-09 4:47 ` Leo
2011-06-09 5:14 ` Glenn Morris
2011-06-09 9:44 ` Leo
2011-06-09 9:54 ` Eli Zaretskii
2011-06-09 9:58 ` Leo
2011-06-09 9:42 ` Leo
2011-06-09 18:09 ` Glenn Morris
2011-06-10 13:59 ` Stefan Monnier
2011-06-10 16:14 ` Ted Zlatanov
2011-06-11 9:58 ` Andrew W. Nosenko
2011-06-11 18:00 ` Juri Linkov
2011-06-12 23:10 ` Andrew W. Nosenko
2011-06-18 19:35 ` Chong Yidong
2011-06-18 20:36 ` Andrew W. Nosenko
2011-09-09 11:39 ` Juri Linkov
2011-09-14 19:04 ` Juri Linkov
2011-09-17 21:28 ` Chong Yidong
2011-09-18 19:33 ` Juri Linkov
2011-09-19 18:52 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjtkuxqo.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=8463@debbugs.gnu.org \
--cc=dan.colascione@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.