From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: issues with recent doprnt-related changes Date: Fri, 06 May 2011 10:33:21 -0300 Message-ID: References: <4DB50AB9.6060100@cs.ucla.edu> <83tydmaeo3.fsf@gnu.org> <4DB65FF1.5010003@cs.ucla.edu> <83aafb8p4a.fsf@gnu.org> <4DB8ABEA.3080503@cs.ucla.edu> <4DB9146D.2040702@cs.ucla.edu> <4DB9E5FF.9020506@cs.ucla.edu> <83d3k571ee.fsf@gnu.org> <4DC10012.8020809@cs.ucla.edu> <4DC1692B.1090101@cs.ucla.edu> <83ei4cnau6.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304688816 19690 80.91.229.12 (6 May 2011 13:33:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 May 2011 13:33:36 +0000 (UTC) Cc: 8545@debbugs.gnu.org, Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 06 15:33:31 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QIL9u-0007et-Rx for ged-emacs-devel@m.gmane.org; Fri, 06 May 2011 15:33:30 +0200 Original-Received: from localhost ([::1]:60198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIL9u-0000En-Bk for ged-emacs-devel@m.gmane.org; Fri, 06 May 2011 09:33:30 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIL9r-0000ET-5D for emacs-devel@gnu.org; Fri, 06 May 2011 09:33:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIL9q-0001m4-6u for emacs-devel@gnu.org; Fri, 06 May 2011 09:33:27 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:44573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIL9q-0001m0-32 for emacs-devel@gnu.org; Fri, 06 May 2011 09:33:26 -0400 Original-Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:40224 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QIL9o-0005ql-OI; Fri, 06 May 2011 09:33:24 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1D9F866168; Fri, 6 May 2011 10:33:21 -0300 (ART) In-Reply-To: <83ei4cnau6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 May 2011 23:36:49 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139174 Archived-At: >> >> It seems from that discussion that strings can contain >> >> MOST_POSITIVE_FIXNUM bytes. >> > I think the conclusion was that it can contain MOST_POSITIVE_FIXNUM >> > _including_the_terminating_null_. >> >> Hmm, that's not how I read >> . >> >> I understood the argument to be that a buffer must contain at most >> MOST_POSITIVE_FIXNUM - 1 bytes due to other reasons, but it's OK >> to have "a string whose length is MOST_POSITIVE_FIXNUM", i.e., >> (= (length STRING) most-positive-fixnum), because we already check >> buffer sizes before inserting strings. If you >> count the trailing byte, the length of the underlying C character >> array would be MOST_POSITIVE_FIXNUM + 1. > Stefan, could you please chime in? I'm not sure I understand the details more than you do. AFAIK the MOST_POSITIVE_FIXNUM limit only comes into play when the number goes through Lisp_Object somewhere. And we never show "length, including terminating nul-byte" to Elisp, so the nul-byte shouldn't matter: while the C array will have size MOST_POSITIVE_FIXNUM + 1, this will only be represented in EMACS_INT which can accommodate it just fine. Stefan