From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9161: 24.0.50; incorrect completion-at-point in *shell* buffer Date: Tue, 23 Aug 2011 01:25:35 -0400 Message-ID: References: <87tyabdfke.fsf@m17n.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314077208 2791 80.91.229.12 (23 Aug 2011 05:26:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 23 Aug 2011 05:26:48 +0000 (UTC) Cc: 9161-done@debbugs.gnu.org To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 23 07:26:44 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QvjVa-0000DJ-86 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Aug 2011 07:26:42 +0200 Original-Received: from localhost ([::1]:37200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvjVZ-0000Y6-I8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Aug 2011 01:26:41 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvjVW-0000Xt-Hn for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 01:26:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QvjVV-0000nX-C7 for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 01:26:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QvjVV-0000nO-9d for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 01:26:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QvjXq-0007ZL-9i for bug-gnu-emacs@gnu.org; Tue, 23 Aug 2011 01:29:02 -0400 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Aug 2011 05:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 9161 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 9161@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 9161-done@debbugs.gnu.org id=D9161.131407728629027 (code D ref 9161); Tue, 23 Aug 2011 05:29:02 +0000 Original-Received: (at 9161-done) by debbugs.gnu.org; 23 Aug 2011 05:28:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvjWv-0007Y8-IL for submit@debbugs.gnu.org; Tue, 23 Aug 2011 01:28:05 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvjWt-0007Y0-A9 for 9161-done@debbugs.gnu.org; Tue, 23 Aug 2011 01:28:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAOE4U05Ld+HZ/2dsb2JhbABBqCF4gUABAQQBViMFCws0EhQYDSQTh3G2OYZIBJ9zhDg X-IronPort-AV: E=Sophos;i="4.68,267,1312171200"; d="scan'208";a="132335356" Original-Received: from 75-119-225-217.dsl.teksavvy.com (HELO ceviche.home) ([75.119.225.217]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 23 Aug 2011 01:25:36 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id DDD836610A; Tue, 23 Aug 2011 01:25:35 -0400 (EDT) In-Reply-To: <87tyabdfke.fsf@m17n.org> (Kenichi Handa's message of "Sun, 24 Jul 2011 21:32:49 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 23 Aug 2011 01:29:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50235 Archived-At: > But, > % cd 0 > is completed to > % cd 0 a Thanks. I think the patch below fixes this problem. Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2011-08-23 05:21:09 +0000 +++ lisp/ChangeLog 2011-08-23 05:23:21 +0000 @@ -1,5 +1,8 @@ 2011-08-23 Stefan Monnier + * shell.el (shell-completion-vars): Set pcomplete-arg-quote-list. + * pcomplete.el (pcomplete-quote-argument): Fix thinko (bug#9161). + * pcomplete.el (pcomplete-parse-comint-arguments): Fix inf-loop. Mark obsolete. * shell.el (shell-parse-pcomplete-arguments): New function. === modified file 'lisp/pcomplete.el' --- lisp/pcomplete.el 2011-08-23 05:21:09 +0000 +++ lisp/pcomplete.el 2011-08-23 05:21:58 +0000 @@ -883,7 +883,7 @@ (or (run-hook-with-args-until-success 'pcomplete-quote-arg-hook filename index) (when (memq c pcomplete-arg-quote-list) - (string "\\" c)) + (string ?\\ c)) (char-to-string c)) (setq index (1+ index)))) filename === modified file 'lisp/shell.el' --- lisp/shell.el 2011-08-23 05:21:09 +0000 +++ lisp/shell.el 2011-08-23 05:21:45 +0000 @@ -412,6 +412,8 @@ shell-dynamic-complete-functions) (set (make-local-variable 'pcomplete-parse-arguments-function) #'shell-parse-pcomplete-arguments) + (set (make-local-variable 'pcomplete-arg-quote-list) + (append "\\ \t\n\r\"'`$|&;(){}[]<>#" nil)) (set (make-local-variable 'pcomplete-termination-string) (cond ((not comint-completion-addsuffix) "") ((stringp comint-completion-addsuffix)