From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 9793@debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#9793: 24.0.90; Unwanted tramp connection on eshell completion.
Date: Sun, 23 Oct 2011 13:47:30 -0400 [thread overview]
Message-ID: <jwvsjmj61qf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wrbxjrfi.fsf@gmx.de> (Michael Albinus's message of "Sat, 22 Oct 2011 11:39:45 +0200")
> `pcomplete-dirs' uses `file-directory-p' as predicate, which is applied
> to all completion candidates. The following patch ought to fix it:
> --8<---------------cut here---------------start------------->8---
> *** /home/albinus/src/emacs/lisp/pcomplete.el.~106161~ 2011-10-22 11:31:11.996458454 +0200
> --- /home/albinus/src/emacs/lisp/pcomplete.el 2011-10-22 11:30:20.796204566 +0200
> ***************
> *** 948,954 ****
> (defsubst pcomplete-dirs (&optional regexp)
> "Complete amongst a list of directories."
> ! (pcomplete-entries regexp 'file-directory-p))
> ;; generation of completion lists
> --- 948,957 ----
> (defsubst pcomplete-dirs (&optional regexp)
> "Complete amongst a list of directories."
> ! (pcomplete-entries regexp
> ! (lambda (dir)
> ! (or (file-remote-p (expand-file-name dir))
> ! (file-directory-p dir)))))
> ;; generation of completion lists
> --8<---------------cut here---------------end--------------->8---
> Comments?
This looks like a workaround rather than a fix. Also, I notice that in
`shell' (rather than `eshell') the problem does not occur. So I'd like
to better understand what's going on.
Stefan
next prev parent reply other threads:[~2011-10-23 17:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 4:53 bug#9793: 24.0.90; Unwanted tramp connection on eshell completion Thierry Volpiatto
2011-10-20 2:31 ` Stefan Monnier
2011-10-20 18:46 ` Thierry Volpiatto
2011-10-20 20:43 ` Stefan Monnier
2011-10-20 21:17 ` Thierry Volpiatto
2011-10-22 9:39 ` Michael Albinus
2011-10-22 10:39 ` Thierry Volpiatto
2011-10-23 17:47 ` Stefan Monnier [this message]
2011-10-24 12:25 ` Michael Albinus
2011-10-24 14:20 ` Stefan Monnier
2011-10-25 10:41 ` Michael Albinus
2011-10-25 12:16 ` Stefan Monnier
2011-10-25 12:56 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjmj61qf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=9793@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.