all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: 10506@debbugs.gnu.org
Subject: bug#10506: 24.0.92; Visiting the Guile v2.0.3 tarball shows binary garbage
Date: Wed, 18 Jan 2012 10:31:51 -0500	[thread overview]
Message-ID: <jwvsjjdrq3y.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <a3ehuxre93.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 17 Jan 2012 20:27:52 -0500")

> I was going to say that I think it would still go wrong in 23.3 if you
> could somehow construct a tar file with a -*- mode -*- entry on the
> first line, but then I discovered inhibit-first-line-modes-regexps.

Thanks for the footwork.
I agree that inhibit-first-line-modes-regexps should apply to all forms
of file-local variables.  I.e. please rename it to
inhibit-file-variables-regexps (with a define-obsolete-variable-alias,
of course).

> A final comment: it seems to me that anything in auto-coding-alist with
> a no-conversion* coding should be in inhibit-first-line-modes-regexps as
> well, since the meaning in both cases is basically "this is a binary
> file". Are there any exceptions?

There could be exceptions, I guess.  I think the way to reduce such
redundancy (without removing the possibility to handle things
differently) is to add indirections: e.g. allow not just regexps but
also major-mode symbols (so auto-mode-alist maps the file name to
a major mode and than this mode can be consulted in
inhibit-file-variables-regexps and auto-coding-alist, and we (w|c)ould
ideally take major-mode inheritance into account so we could make
tar-mode and image-mode inherit from a binary-mode parent and only have
binary-mode listed in those two lists).


        Stefan





  parent reply	other threads:[~2012-01-18 15:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14 21:10 bug#10506: 24.0.92; Visiting the Guile v2.0.3 tarball shows binary garbage Eli Zaretskii
2012-01-14 22:16 ` Glenn Morris
2012-01-15  5:17   ` Eli Zaretskii
2012-01-15  5:58     ` Glenn Morris
2012-01-18  1:27     ` Glenn Morris
2012-01-18  1:40       ` Glenn Morris
2012-01-18 15:31       ` Stefan Monnier [this message]
2012-01-21  0:49         ` Glenn Morris
2012-01-21 10:23           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsjjdrq3y.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=10506@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.