From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Aurélien Aptel" <aurelien.aptel+emacs@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] add "underwave" face attribute
Date: Fri, 27 Jan 2012 10:50:19 -0500 [thread overview]
Message-ID: <jwvsjj1qh9f.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CA+5B0FN8BdrZJwp1kupyB4veAOoxwLirU0dH_KndrPg0OFVcYw@mail.gmail.com> ("Aurélien Aptel"'s message of "Thu, 26 Jan 2012 21:16:11 +0100")
> I would love to see this merged in Emacs so -- if everything is
> alright -- what's the next step?
The feature sounds good, I'll let others judge the implementation
quality, but I have one issue with the "user interface": do we really
want to let faces specify underline and underwave separately?
Maybe another approach is to include it as an additional value
for underline (which can currently be either a boolean or a color name,
so we'd have to extend the set of value so as to be able to specify
shape and color separately).
Stefan
next prev parent reply other threads:[~2012-01-27 15:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 20:16 [patch] add "underwave" face attribute Aurélien Aptel
2012-01-27 15:50 ` Stefan Monnier [this message]
2012-01-27 17:08 ` Drew Adams
2012-01-31 23:38 ` Aurélien Aptel
2012-02-01 16:21 ` Leo
2012-02-01 23:11 ` Juri Linkov
2012-02-02 0:18 ` Aurélien Aptel
2012-02-02 0:52 ` Juanma Barranquero
2012-02-03 19:37 ` Aurélien Aptel
2012-02-04 8:14 ` Jan Djärv
2012-02-04 18:22 ` Aurélien Aptel
2012-02-06 0:18 ` Alp Aker
2012-02-06 0:24 ` Aurélien Aptel
2012-02-06 0:51 ` Alp Aker
2012-02-06 0:55 ` Aurélien Aptel
2012-02-06 1:14 ` Alp Aker
2012-02-06 11:27 ` Aurélien Aptel
2012-02-06 17:20 ` Aurélien Aptel
2012-02-12 11:19 ` Aurélien Aptel
2012-02-12 16:59 ` Stefan Monnier
2012-02-12 17:08 ` Leo
2012-02-12 17:29 ` Aurélien Aptel
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 17:55 Aurélien Aptel
2012-01-27 4:01 ` Leo
2012-01-27 10:25 ` Andreas Schwab
2012-01-27 13:02 ` Aurélien Aptel
2012-01-27 14:06 ` Andreas Schwab
2012-01-27 14:55 ` Aurélien Aptel
2012-01-27 15:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjj1qh9f.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=aurelien.aptel+emacs@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.