From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10181: 24.0.92; [wishlist] split `diff-refine-change' in several faces Date: Sun, 20 May 2012 11:06:38 -0400 Message-ID: References: <87txzftzn0.fsf@mail.jurta.org> <87396yxr9u.fsf@mail.jurta.org> <87d361w2ea.fsf@mail.jurta.org> <87aa13k9o1.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337526462 19037 80.91.229.3 (20 May 2012 15:07:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 May 2012 15:07:42 +0000 (UTC) Cc: 10181@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 20 17:07:40 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SW7jM-00064V-Qs for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2012 17:07:36 +0200 Original-Received: from localhost ([::1]:59780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SW7jM-0004V3-3B for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2012 11:07:36 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SW7jI-0004Ub-Sc for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 11:07:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SW7jH-0003A2-1U for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 11:07:32 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SW7jG-00039x-UI for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 11:07:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SW7jl-0005TQ-Tx for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 11:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 May 2012 15:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10181 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10181-submit@debbugs.gnu.org id=B10181.133752645621009 (code B ref 10181); Sun, 20 May 2012 15:08:01 +0000 Original-Received: (at 10181) by debbugs.gnu.org; 20 May 2012 15:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:35499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SW7jM-0005So-FJ for submit@debbugs.gnu.org; Sun, 20 May 2012 11:07:36 -0400 Original-Received: from ironport-out.teksavvy.com ([206.248.143.162]:39888) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SW7j2-0005SG-RE for 10181@debbugs.gnu.org; Sun, 20 May 2012 11:07:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmgFAOMAh09FpZld/2dsb2JhbAA3oRSCLoEIgXYBBVYjEAs0EhQYDSSqJIwbSQwDgz4Dg3AEkQiSW4RY X-IronPort-AV: E=Sophos;i="4.73,1,1325480400"; d="scan'208";a="181436626" Original-Received: from 69-165-153-93.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.93]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 May 2012 11:06:38 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 630F25979D; Sun, 20 May 2012 11:06:38 -0400 (EDT) In-Reply-To: <87aa13k9o1.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 20 May 2012 02:55:58 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60234 Archived-At: > (defface diff-removed > - '((t :inherit diff-changed)) > + '((((class color) (min-colors 88)) > + :background "#ffdddd") > + (((class color)) > + :foreground "red")) Please keep the inheritance, even if the default overrides all fields. > + ((not (or (get diff-removed-face 'customized-face) > + (get diff-removed-face 'saved-face) > + (get diff-added-face 'customized-face) > + (get diff-added-face 'saved-face))) Making decisions based on whether something is customized or not sounds fundamentally wrong. Maybe you meant something more like: ((and (face-equal diff-changed-face diff-added-face) (face-equal diff-changed-face diff-removed-face)) Tho, I don't see what's the point of this `changed' color-scheme: you get the same visual result if you use the `removed-added' color scheme and pretty much the same resource usage. The only point of the distinction between removed-added and changed-removed-added is to avoid the additional resource usage when it would have no visual effect. > + ((or (get diff-changed-face 'customized-face) > + (get diff-changed-face 'saved-face)) > + 'changed-removed-added) This is very wrong > +(defface diff-refine-removed > + '((((class color) (min-colors 88)) > + :background "#ffaaaa") > + (t :inherit diff-removed :inverse-video t)) > + "Face used for removed characters shown by `diff-refine-hunk'." > + :group 'diff-mode > + :version "24.2") > + > +(defface diff-refine-added > + '((((class color) (min-colors 88)) > + :background "#aaffaa") > + (t :inherit diff-added :inverse-video t)) > + "Face used for added characters shown by `diff-refine-hunk'." > + :group 'diff-mode > + :version "24.2") This is just an accidental left-over, right? Stefan