From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Masatake YAMATO <yamato@redhat.com>
Cc: 11711@debbugs.gnu.org, Stefan Merten <smerten@oekonux.de>
Subject: bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el
Date: Thu, 14 Jun 2012 21:46:00 -0400 [thread overview]
Message-ID: <jwvsjdx4agh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20120615.041527.616439723447762585.yamato@redhat.com> (Masatake YAMATO's message of "Fri, 15 Jun 2012 04:15:27 +0900 (JST)")
> This is not a bug report. This is a request to merge a patch
> to the offcial source tree.
> 2012-06-13 Masatake YAMATO <yamato@redhat.com>
> * textmodes/rst.el (rst-mode, rst-imenu-index): Added
> imenu and which-func support.
I'll let the other Stefan decide what to do with it. It looks
pretty good for me. Just a few nitpicks below:
> + ;; Imenu
> + (set (make-local-variable 'imenu-create-index-function) 'rst-imenu-index)
> +
> + ;; Which func
> + (when (and (boundp 'which-func-modes) (listp which-func-modes))
> + (add-to-list 'which-func-modes 'rst-mode))
> +
> ;; Font lock.
Try to punctuate your comments.
> +(defun rst-imenu-find-adornments-for-position (adornments p)
> + "Find adornments cell for position P in ADORNMENTS"
And do punctuate your docstring (C-u M-x checkdoc-current-buffer RET
might help you catch such things).
Stefan
next prev parent reply other threads:[~2012-06-15 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 19:15 bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el Masatake YAMATO
2012-06-15 1:46 ` Stefan Monnier [this message]
2012-06-16 22:33 ` Masatake YAMATO
2012-06-18 1:59 ` Stefan Monnier
2012-06-18 9:28 ` Stefan Merten
2012-06-18 9:44 ` Stefan Merten
2012-06-18 19:25 ` Stefan Monnier
2012-06-18 9:57 ` Stefan Merten
2012-06-19 3:33 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjdx4agh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=11711@debbugs.gnu.org \
--cc=smerten@oekonux.de \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.