From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: The rest of xVARs
Date: Fri, 10 Aug 2012 11:18:26 -0400 [thread overview]
Message-ID: <jwvsjbueq38.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <502499F9.9030204@yandex.ru> (Dmitry Antipov's message of "Fri, 10 Aug 2012 09:19:53 +0400")
>>>>> I can't continue without solving (B|K)VARs issue, and X = B->field/
>>>>> BSET(B, field, X) is enough for my purposes;
>>>> You can split the BVAR into a BGET and BSET for now.
>>> OK, the patch is > 200K uncompressed.
>> Here's a simpler solution: split BVAR into BVAR and BSET. I'm sure the
>> patch will substantially smaller and hence cause much fewer conflicts.
> OK
Looks good, feel free to install.
>> Stefan "tired of resolving cosmetic conflicts with your patches"
> Coccinelle tends to eat spaces and tabs (especially between function
> name and '(' opens an argument list),so I do quite a lot of manual
> adjustments to fit our coding style; but sometimes I can miss the
> poorly formatted entry :-(.
You've done a great job of adjusting it seems, since all the conflicts
I got were always due to real (tho usually cosmetic, such as
introducing/removing FVAR) changes.
Stefan "hovering between 1MB and 2MB of local changes, many of
them cosmetic"
prev parent reply other threads:[~2012-08-10 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50214432.5040906@yandex.ru>
[not found] ` <jwvlihqih7o.fsf-monnier+emacs@gnu.org>
2012-08-09 6:14 ` The rest of xVARs Dmitry Antipov
2012-08-09 12:52 ` Stefan Monnier
[not found] ` <5023F621.1020107@yandex.ru>
[not found] ` <jwvipcr7tgm.fsf-monnier+emacs@gnu.org>
2012-08-10 5:19 ` Dmitry Antipov
2012-08-10 15:18 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjbueq38.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.