From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race Date: Tue, 02 Oct 2012 21:56:46 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349233289 24737 80.91.229.3 (3 Oct 2012 03:01:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Oct 2012 03:01:29 +0000 (UTC) Cc: emacs-diffs@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 03 05:01:30 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TJFCz-0000Nk-6f for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2012 05:01:13 +0200 Original-Received: from localhost ([::1]:52182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJFCt-0002a9-Nd for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 23:01:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJFCr-0002a2-Ai for emacs-devel@gnu.org; Tue, 02 Oct 2012 23:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJFCp-0000wS-2z for emacs-devel@gnu.org; Tue, 02 Oct 2012 23:01:05 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:20249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJFCo-0000wG-Um for emacs-devel@gnu.org; Tue, 02 Oct 2012 23:01:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEDrQDgQiCFgEFViMQCzQHCxQYDSSIIboJkEQDnjmEeoFYgjBV X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200524507" Original-Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2012 23:01:01 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8777E594D2; Tue, 2 Oct 2012 23:01:00 -0400 (EDT) Resent-Message-ID: Resent-To: emacs-devel@gnu.org Resent-From: Stefan Monnier Resent-Date: Tue, 02 Oct 2012 23:01:00 -0400 Original-Received: from pinpin.iro.umontreal.ca (pinpin.iro.umontreal.ca [132.204.24.52]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id B2C2586AE7 for ; Tue, 2 Oct 2012 21:57:05 -0400 (EDT) Original-Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by pinpin.iro.umontreal.ca (Postfix) with ESMTP id 1CFB73B8CF6 for ; Tue, 2 Oct 2012 21:56:48 -0400 (EDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09FxLQG/2dsb2JhbABEDrQDgQiCFgEFViMQCzQHCxQYDSSIIboJkEQDnjmEeoFYgjBV X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="200522248" Original-Received: from 69-196-180-6.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.6]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2012 21:56:47 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 03AD1594D2; Tue, 2 Oct 2012 21:56:46 -0400 (EDT) In-Reply-To: (Paul Eggert's message of "Tue, 02 Oct 2012 12:38:10 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.6, requis 5, autolearn=not spam, BAYES_00 -2.60, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153975 Archived-At: > + /* record_backtrace uses hash functions that call Fequal, which > + uses QUIT, which can call malloc, which can cause disaster in > + a signal handler. So inhibit QUIT. */ Actually, we'd probably be better off using a different hash-function (and equality test) so as to make sure we don't run QUIT at all. We could use it to improve the equality function such that different closures coming from the same source code (IOW different instances of the same source function) are considered equal. Stefan