all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 13017@debbugs.gnu.org
Subject: bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook
Date: Tue, 27 Nov 2012 20:42:35 -0500	[thread overview]
Message-ID: <jwvsj7u5wso.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87obii60zj@ch.ristopher.com> (Christopher Schmidt's message of "Wed, 28 Nov 2012 00:10:54 +0000 (GMT)")

> In minibuf-eldef-setup-minibuffer there is this form

>     (add-hook 'post-command-hook #'minibuf-eldef-update-minibuffer nil t)

> I think this is not correct.  The APPEND parameter of add-hook should be
> t so all changes made to the minibuffer content by previous functions in
> post-command-hook are taken into account by
> minibuf-eldef-update-minibuffer.

That sounds reasonable, but I'd be happier to know of a concrete example
where this was needed.


        Stefan





  reply	other threads:[~2012-11-28  1:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28  0:10 bug#13017: 24.2.90; minibuf-eldef-setup-minibuffer should append minibuf-eldef-update-minibuffer to post-command-hook Christopher Schmidt
2012-11-28  1:42 ` Stefan Monnier [this message]
2014-02-06  0:55   ` Lars Ingebrigtsen
2014-04-16 17:03     ` Christopher Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsj7u5wso.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=13017@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.