all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "David Cadé" <codename68@gmail.com>
Cc: 13143-done@debbugs.gnu.org
Subject: bug#13143: 24.2; mpc.el: mpc-songs-refresh: Args out of range
Date: Wed, 12 Dec 2012 11:04:46 -0500	[thread overview]
Message-ID: <jwvsj7bpcjn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1212121310450.11192@alfheim> ("David Cadé"'s message of "Wed, 12 Dec 2012 13:55:50 +0100 (CET)")

Version: 24.4

> I looked at the code of this function, and from what I can gather, the bug
> seems to be in:
> (substring text 0 (- size postwidth textwidth 1))

Yes, that's also what I bumped into.  Great minds debug alike!

The patch looks good, installed in `trunk', thank you very much.


        Stefan


PS: I guess I didn't know about truncate-string-to-width when I wrote
this code.  But looking at truncate-string-to-width, I hope it won't
impact performance too much.





  parent reply	other threads:[~2012-12-12 16:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 15:03 bug#13143: 24.2; mpc.el: mpc-songs-refresh: Args out of range David Cadé
2012-12-12  1:56 ` Stefan Monnier
2012-12-12  6:24   ` Thierry Volpiatto
2012-12-12 12:55   ` David Cadé
2012-12-12 14:00     ` David Cadé
2012-12-12 16:04     ` Stefan Monnier [this message]
2012-12-12 16:10       ` Bastien
2012-12-12 16:40         ` David Cadé
2012-12-12 16:51           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsj7bpcjn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=13143-done@debbugs.gnu.org \
    --cc=codename68@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.