From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: imenu issue from Bug #13438 Date: Mon, 21 Jan 2013 20:07:31 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358816862 8462 80.91.229.3 (22 Jan 2013 01:07:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2013 01:07:42 +0000 (UTC) Cc: Emacs-Devel devel To: Fabian Ezequiel Gallina Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 22 02:08:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TxSLF-0002BU-2r for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2013 02:07:57 +0100 Original-Received: from localhost ([::1]:51778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxSKx-0004kK-Rd for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2013 20:07:39 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxSKu-0004kF-F5 for emacs-devel@gnu.org; Mon, 21 Jan 2013 20:07:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxSKt-0006iK-By for emacs-devel@gnu.org; Mon, 21 Jan 2013 20:07:36 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxSKt-0006iD-7P for emacs-devel@gnu.org; Mon, 21 Jan 2013 20:07:35 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0M17QHM023057; Mon, 21 Jan 2013 20:07:27 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D346EAE361; Mon, 21 Jan 2013 20:07:31 -0500 (EST) In-Reply-To: (Fabian Ezequiel Gallina's message of "Mon, 21 Jan 2013 18:09:20 -0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4468=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4468> : streams <892521> : uri <1324505> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156563 Archived-At: > Here's a mindless quick patch that seems to fix the problem. I could > install it myself but I'd like some input first. Calling beginning-of-defun in such generic code is not an option, because this function only works properly in those major modes that set it up appropriately. I think testing bobp makes more sense (and python's function should make sure it eventually either returns nil or moves up to bob). Stefan