From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13609: 24.2.92; completion-list-insert-choice-function Date: Sun, 03 Feb 2013 08:51:39 -0500 Message-ID: References: <87a9rm7kfa.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359899539 13816 80.91.229.3 (3 Feb 2013 13:52:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Feb 2013 13:52:19 +0000 (UTC) Cc: 13609@debbugs.gnu.org To: "Roland Winkler" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 03 14:52:33 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U1zzd-0008OC-7P for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Feb 2013 14:52:25 +0100 Original-Received: from localhost ([::1]:50427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1zzK-0005Bu-VD for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Feb 2013 08:52:06 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1zzI-0005Ai-6A for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 08:52:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1zzH-0003WL-9W for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 08:52:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1zzH-0003WH-69 for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 08:52:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U200D-0000RP-Vu for bug-gnu-emacs@gnu.org; Sun, 03 Feb 2013 08:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Feb 2013 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13609-submit@debbugs.gnu.org id=B13609.13598995611665 (code B ref 13609); Sun, 03 Feb 2013 13:53:01 +0000 Original-Received: (at 13609) by debbugs.gnu.org; 3 Feb 2013 13:52:41 +0000 Original-Received: from localhost ([127.0.0.1]:33768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1zzt-0000Qo-6M for submit@debbugs.gnu.org; Sun, 03 Feb 2013 08:52:41 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:39928) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1zzr-0000Qh-Qr for 13609@debbugs.gnu.org; Sun, 03 Feb 2013 08:52:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpZnt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="323881" Original-Received: from 69-165-153-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.153.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Feb 2013 08:51:39 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 68FE159527; Sun, 3 Feb 2013 08:51:39 -0500 (EST) In-Reply-To: <87a9rm7kfa.fsf@gnu.org> (Roland Winkler's message of "Sat, 02 Feb 2013 10:24:57 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70643 Archived-At: > So I suggest to rename completion--replace to completion-replace > to make it clear that other code may use this function. No, because some other package may already have changed completion-list-insert-choice-function, so you should really read the current value of completion-list-insert-choice-function, and then call that (via `funcall') rather than hard-coding completion--replace. > (Or solve this problem in some other way that other code may rely upon.) As a matter of fact there's a new feature in trunk that does just that: `add-function'. Stefan