From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Roland Winkler" <winkler@gnu.org>
Cc: 13609@debbugs.gnu.org
Subject: bug#13609: 24.2.92; completion-list-insert-choice-function
Date: Sun, 03 Feb 2013 08:51:39 -0500 [thread overview]
Message-ID: <jwvsj5dmrru.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a9rm7kfa.fsf@gnu.org> (Roland Winkler's message of "Sat, 02 Feb 2013 10:24:57 -0600")
> So I suggest to rename completion--replace to completion-replace
> to make it clear that other code may use this function.
No, because some other package may already have changed
completion-list-insert-choice-function, so you should really read the
current value of completion-list-insert-choice-function, and then call
that (via `funcall') rather than hard-coding completion--replace.
> (Or solve this problem in some other way that other code may rely upon.)
As a matter of fact there's a new feature in trunk that does just that:
`add-function'.
Stefan
next prev parent reply other threads:[~2013-02-03 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 16:24 bug#13609: 24.2.92; completion-list-insert-choice-function Roland Winkler
2013-02-03 13:51 ` Stefan Monnier [this message]
2013-02-03 15:46 ` Roland Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsj5dmrru.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13609@debbugs.gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.