From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f) Date: Thu, 27 Jun 2013 14:15:22 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1372356974 27859 80.91.229.3 (27 Jun 2013 18:16:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Jun 2013 18:16:14 +0000 (UTC) Cc: 14734-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 27 20:16:14 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UsGjo-0002iQ-VT for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 20:16:09 +0200 Original-Received: from localhost ([::1]:48453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGjo-0004hW-BS for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jun 2013 14:16:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGjl-0004hQ-Ql for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsGjj-0004Sb-5S for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:16:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGjj-0004SW-2s for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UsGji-0001F5-RA for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2013 14:16:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2013 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Mail-Followup-To: 14734@debbugs.gnu.org, monnier@iro.umontreal.ca, drew.adams@oracle.com Original-Received: via spool by 14734-done@debbugs.gnu.org id=D14734.13723569324699 (code D ref 14734); Thu, 27 Jun 2013 18:16:02 +0000 Original-Received: (at 14734-done) by debbugs.gnu.org; 27 Jun 2013 18:15:32 +0000 Original-Received: from localhost ([127.0.0.1]:45597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsGjD-0001Dh-9X for submit@debbugs.gnu.org; Thu, 27 Jun 2013 14:15:31 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:54416) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UsGjB-0001DP-3R; Thu, 27 Jun 2013 14:15:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17311765" Original-Received: from 76-10-154-64.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Jun 2013 14:15:17 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E77656BCBC; Thu, 27 Jun 2013 14:15:22 -0400 (EDT) In-Reply-To: (Drew Adams's message of "Thu, 27 Jun 2013 10:08:41 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75651 Archived-At: tags 14734 wontfix thanks > :around advice: `ad-Advice-isearch-forward' [...] > It is also incorrect. The advice is :before, not :around. It is correct: the ad-Advice-isearch-forward advice is an around advice (and it is not your advice, it's internal as you say). If you click on it, you'll see your before advice, properly labeled. If you don't want to see the internal thingy, then use the new advice-add rather than the old defadvice. Stefan