From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114523: * progmodes/octave.el (inferior-octave-mode): Call Date: Fri, 04 Oct 2013 13:53:10 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380913566 14186 80.91.229.3 (4 Oct 2013 19:06:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Oct 2013 19:06:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 04 21:06:08 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VSAhU-0004PF-1A for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 21:06:08 +0200 Original-Received: from localhost ([::1]:49236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAhT-0008Ub-K4 for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 15:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAg5-0006xh-9d for emacs-devel@gnu.org; Fri, 04 Oct 2013 15:04:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSAfx-0001Mp-PZ for emacs-devel@gnu.org; Fri, 04 Oct 2013 15:04:41 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSAfx-0001Mc-LK for emacs-devel@gnu.org; Fri, 04 Oct 2013 15:04:33 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r94J4SSX007812; Fri, 4 Oct 2013 15:04:31 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id DC8FEB4371; Fri, 4 Oct 2013 13:53:10 -0400 (EDT) In-Reply-To: (Leo Liu's message of "Fri, 04 Oct 2013 15:13:00 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4721=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4721> : inlines <126> : streams <1050162> : uri <1555789> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163859 Archived-At: > + * progmodes/octave.el (inferior-octave-mode): Call > + compilation-forget-errors. This call doesn't seem very useful: at that point in time, there aren't any errors parsed yet anyway. The need for compilation-forget-errors is because in a comint-buffer, you can have error "foo:3:Syntax error" appear many times following different commands loading different versions of "foo" (e.g. because it was edited in the mean time). So you need to call compilation-forget-errors whenever you know that the underlying process will look at "files that have been modified". It's often difficult to know "the right place" where it should be called, but typically -send-region, and related functions are good spots. Stefan