all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jorgen Schaefer <forcer@forcix.cx>
Cc: emacs-devel@gnu.org
Subject: Re: minibuffer.el completion bug with markers
Date: Thu, 03 Oct 2013 22:24:03 -0400	[thread overview]
Message-ID: <jwvsiwheqd8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20130921213421.4e7b91ec@forcix.kollektiv-hamburg.de> (Jorgen Schaefer's message of "Sat, 21 Sep 2013 21:34:21 +0200")

> The recent changes to minibuffer.el broke completion functions when
> they use markers to define where the completed text starts and ends.

Thanks, installed.


        Stefan


> (with-temp-buffer
>   (cl-flet ((test/completion-at-point ()
>                (list (copy-marker (point-min))
>                      (copy-marker (point))
>                      'test/completion-table))
>             (test/completion-table (string pred action)
>                (if (eq action 'lambda)
>                    nil
>                  "test: ")))
>     (let ((completion-at-point-functions '(test/completion-at-point)))
>       (insert "TEST")
>       (completion-at-point)
>       (assert (equal (buffer-string)
>                      "test: ")))))

Thanks for the test, tho it fails.  I think you meant to use `flet'
above rather than `cl-flet'.  Those are quite different (basically,
`flet' provides dynamically scoped definitions, whereas
`cl-flet' provides lexically scoped definitions).


        Stefan



      reply	other threads:[~2013-10-04  2:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-21 19:34 minibuffer.el completion bug with markers Jorgen Schaefer
2013-10-04  2:24 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsiwheqd8.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=forcer@forcix.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.