From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Nakayama Kenjiro <nakayamakenjiro@gmail.com>
Cc: 16141@debbugs.gnu.org
Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.
Date: Sat, 14 Dec 2013 09:22:50 -0500 [thread overview]
Message-ID: <jwvsitvzf7g.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAA_ZtA9NueC3V-yTcX11qb_2+zNK0pJw8xr0RLWHnaEN92Uu+w@mail.gmail.com> (Nakayama Kenjiro's message of "Sat, 14 Dec 2013 21:05:40 +0900")
> It is useful, if we can jump to next select fiedld with tab commadn.
> Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
Thank you for your patch. I'll let the EWW maintainers decide what to
do with it, but I just wanted to point out:
> * net/eww.el (eww-tag-select): added text-property to jump to
> next select field.
Such comments should describe what the change *does* rather than what it
*did*, i.e. use the present tense (and capitalize the word after the
colon since it starts a sentence).
Stefan
next prev parent reply other threads:[~2013-12-14 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 12:05 bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field Nakayama Kenjiro
2013-12-14 14:22 ` Stefan Monnier [this message]
2013-12-14 16:18 ` Kenjiro NAKAYAMA
2013-12-21 20:48 ` Ted Zlatanov
2013-12-22 1:56 ` Kenjiro NAKAYAMA
2013-12-22 22:41 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsitvzf7g.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16141@debbugs.gnu.org \
--cc=nakayamakenjiro@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.