From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Doc View Page Problems Date: Wed, 16 Apr 2014 10:18:29 -0400 Message-ID: References: <87mwfmwwsi.fsf@gnu.org> <8738hdh1ae.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1397657943 17783 80.91.229.3 (16 Apr 2014 14:19:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Apr 2014 14:19:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ian D Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 16 16:18:56 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WaQfw-0008Vf-2P for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2014 16:18:56 +0200 Original-Received: from localhost ([::1]:54796 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaQfv-0006XG-LT for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2014 10:18:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaQfl-0006Q9-IO for emacs-devel@gnu.org; Wed, 16 Apr 2014 10:18:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WaQfe-00021A-3R for emacs-devel@gnu.org; Wed, 16 Apr 2014 10:18:45 -0400 Original-Received: from relais.videotron.ca ([24.201.245.36]:53788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaQfW-0001yr-5P; Wed, 16 Apr 2014 10:18:30 -0400 Original-Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0N4400KKSNQTVL80@VL-VM-MR006.ip.videotron.ca>; Wed, 16 Apr 2014 10:18:29 -0400 (EDT) Original-Received: by ceviche.home (Postfix, from userid 20848) id 3329466644; Wed, 16 Apr 2014 10:18:29 -0400 (EDT) In-reply-to: <8738hdh1ae.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171455 Archived-At: > I put the ChangeLog entry at the end of this email. Thanks. >>> (setf (doc-view-current-page) page >>> + (image-mode-window-get 'page t) page ;; Update the default page. >> Wouldn't it be better to do that directly inside image-mode-window-put? > I used `image-mode-window-get' because that was what was being > used through most of the document (including the line above > it). It could just as easily be (image-mode-window-put 'page > page t). No, I really meant to do it *inside* image-mode-window-put, not to use image-mode-window-put instead of setf'ing image-mode-window-get. Stefan