all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andy Grover <andy@groveronline.com>
Cc: 18952-done@debbugs.gnu.org
Subject: bug#18952: 24.4; delete weirdness in cua mode
Date: Fri, 07 Nov 2014 14:56:07 -0500	[thread overview]
Message-ID: <jwvsihukcrs.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <545B1821.8070007@groveronline.com> (Andy Grover's message of "Wed, 05 Nov 2014 22:41:37 -0800")

Version:24.5

> Ah! ok, I also have cua-highlight-region-shift-only t in my Customize
> section, so I hit this without trying? But here's a way to repro,
> starting from emacs -Q:

Ah, I see it now.  I installed the patch below, which seems to fix it.
Thanks,


        Stefan


=== modified file 'lisp/emulation/cua-base.el'
--- lisp/emulation/cua-base.el	2014-10-31 15:31:27 +0000
+++ lisp/emulation/cua-base.el	2014-11-07 19:51:19 +0000
@@ -1199,7 +1199,7 @@
 (defun cua--select-keymaps ()
   ;; Setup conditions for selecting the proper keymaps in cua--keymap-alist.
   (setq cua--ena-region-keymap
-	(and mark-active (not deactivate-mark)))
+	(and (region-active-p) (not deactivate-mark)))
   (setq cua--ena-prefix-override-keymap
 	(and cua--ena-region-keymap
 	     cua-enable-cua-keys






      reply	other threads:[~2014-11-07 19:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  7:11 bug#18952: 24.4; delete weirdness in cua mode Andy Grover
2014-11-05 16:03 ` Eli Zaretskii
2014-11-05 19:02   ` Andy Grover
2014-11-05 20:16     ` Stefan Monnier
2014-11-05 20:29       ` Andy Grover
2014-11-05 22:45         ` Stefan Monnier
2014-11-06  3:06         ` Stefan Monnier
2014-11-06  6:41           ` Andy Grover
2014-11-07 19:56             ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsihukcrs.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=18952-done@debbugs.gnu.org \
    --cc=andy@groveronline.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.