From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 4d74873 2/2: Fix miscellaneous glitches in cc-mode.el. Fixes debbugs#20245. Date: Sat, 12 Sep 2015 00:01:10 -0400 Message-ID: References: <20150406222445.3566.44486@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1442030495 3501 80.91.229.3 (12 Sep 2015 04:01:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Sep 2015 04:01:35 +0000 (UTC) Cc: Alan Mackenzie To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 12 06:01:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zac0E-0000uw-6q for ged-emacs-devel@m.gmane.org; Sat, 12 Sep 2015 06:01:26 +0200 Original-Received: from localhost ([::1]:59405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zac0D-0000RB-JX for ged-emacs-devel@m.gmane.org; Sat, 12 Sep 2015 00:01:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zac02-0000Ql-Fc for emacs-devel@gnu.org; Sat, 12 Sep 2015 00:01:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zabzz-000592-Al for emacs-devel@gnu.org; Sat, 12 Sep 2015 00:01:14 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:40849) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zabzz-00058w-6f for emacs-devel@gnu.org; Sat, 12 Sep 2015 00:01:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/zi6xEVcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQRWIxALNAcLFBgNiGPPIwEBAQcBAQEBHos6hQUHFoQXAQSqYYhegUUjgjuBWSKCeAEBAQ X-IPAS-Result: A0CXDQA731xV/zi6xEVcgxCEAshgBAICgTw8EQEBAQEBAQGBCkEFg10BAQRWIxALNAcLFBgNiGPPIwEBAQcBAQEBHos6hQUHFoQXAQSqYYhegUUjgjuBWSKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="164613223" Original-Received: from 69-196-186-56.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([69.196.186.56]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 12 Sep 2015 00:01:10 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 64BFBAE12C; Sat, 12 Sep 2015 00:01:10 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Mon, 06 Apr 2015 22:24:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189850 Archived-At: > + (let (before-change-functions after-change-functions) Let-binding these vars can have some annoying side effects. So instead you should use (let ((inhibit-modification-hooks t)) ...) This variable exists in Emacs since Emacs-21. AFAICT it does not exist in XEmacs, but that shouldn't matter since XEmacs doesn't run before/after-change-functions upon text-property changes, IIUC. Stefan PS: Even better would be to use `with-silent-modifications', but that's a fairly recent addition.