From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/no-undo-boundary-on-secondary-buffer-change f59d1be: Move undo amalgamation to lisp. Date: Tue, 27 Oct 2015 10:50:47 -0400 Message-ID: References: <20151005134118.10933.50859@vcs.savannah.gnu.org> <87h9m52sh8.fsf@russet.org.uk> <87h9lqbk8m.fsf@russet.org.uk> <87mvvc9g3m.fsf@russet.org.uk> <87wpu8lbtp.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1445957678 13475 80.91.229.3 (27 Oct 2015 14:54:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Oct 2015 14:54:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 27 15:54:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zr5dt-0007DG-Na for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2015 15:54:29 +0100 Original-Received: from localhost ([::1]:60233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5dt-00019P-AH for ged-emacs-devel@m.gmane.org; Tue, 27 Oct 2015 10:54:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5aR-0005CH-CJ for emacs-devel@gnu.org; Tue, 27 Oct 2015 10:50:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr5aO-0004UR-1A for emacs-devel@gnu.org; Tue, 27 Oct 2015 10:50:55 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:35648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr5aN-0004U3-Oy for emacs-devel@gnu.org; Tue, 27 Oct 2015 10:50:51 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t9REolNW030726; Tue, 27 Oct 2015 10:50:48 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id C594C66349; Tue, 27 Oct 2015 10:50:47 -0400 (EDT) In-Reply-To: <87wpu8lbtp.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 27 Oct 2015 12:45:22 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5472=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5472> : inlines <3953> : streams <1528281> : uri <2071295> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192730 Archived-At: > I have noticed one problem case. The *scratch* buffer is created without > an undo-boundary after the ";;; This buffer is..." message. I think this > is a bootstrap problem and can be fixed by adding an undo-boundary call > to startup.el. The boundary is supposed to be added just before the first command (since undo-boundaries are added by the command loop right before running a command). so maybe the problem is that it doesn't get added to your list of "buffers with undo elements"? > Other than this, are these changes ready to go? I'll let you know as soon as I find the time to review it, Stefan